Bug fix in radiation aerosols to fix restart reproducibility issue with NEPTUNE model #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.f to run from 1 instead of i1/j1 to fix a restart reproducibility issue with NEPTUNE
climbfuji
requested review from
Qingfu-Liu,
dustinswales,
grantfirl and
rhaesung
as code owners
grantfirl
approved these changes
Jun 13, 2025
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Looks fine. Nice debugging. Is this OK to combine with another PR since it doesn't change baselines?
Author
Yes please, thanks |
Qingfu-Liu
approved these changes
Jun 13, 2025
rhaesung
approved these changes
Jun 17, 2025
This was referenced Jun 27, 2025
Collaborator
|
Combined into #295. Keeping open until merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Change indices
i3andj3in routineaer_propertyinradiation_aerosols.fto run from 1 instead ofi1/j1to fix a restart reproducibility issue with NEPTUNE. See NCAR#1140 for more information.Tests Conducted:
Dependencies:
No parents created. This PR will be combined with something else, I assume.
Documentation:
See issue.
Issue (optional):
This will eventually resolve NCAR#1140 once it gets merged into NCAR main.
Contributors (optional):
All credits go to @areinecke for this work, I am just the messenger.