Combo PR (merge from NCAR/main, ECMWF GWD, maxmf bugfix, NEPTUNE reproducibility, mersenne bugfix) #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers.F90; update CODEOWNERS physics/docs/ccpp_doxyfile
…d Bnv2 array in line 350
UFS-dev PR#235
… into ufs-dev-pr251
Ufs dev PR#251
UFS-dev PR#252 Tenth reconciliation PR from production/RRFS.v1
…nit_main Bug fix in physics/GWD/ugwp_driver_v0.F to prevent using uninitialized Bnv2 array in line 350
…ure/add_nrl_parse_tracers_ncar_main
…cers_ncar_main Remove GFDL_parse_tracers.F90 (was: Add NRL_parse_tracers.F90 as a replacement for GFDL_parse_tracers.F90 for NEPTUNE)
UFS dev combined PR#232 and NCAR#256
Ufs dev pr246
UFS-dev PR#258
…' into ufs-dev-PR259-CMake-changes
…ne used by modules
…ersion CI Hotfix: bumping Ubuntu version to latest
Collaborator
Author
|
@MicroTed Here are the same changes that were merged into NCAR:main related to namelists if you'd like to take a look and review before it goes into ufs-community:ufs/dev |
This was referenced Jun 27, 2025
Collaborator
|
@grantfirl It looks like it serves the current need. I may tweak it in a later update but no time for that right now. |
MicroTed
approved these changes
Jun 30, 2025
dustinswales
approved these changes
Jun 30, 2025
tlim_fgf is defined above this in get_spectra_tau_nstgw but not in get_spectra_tau_okw
Fix warning of: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value. [ZLWB]
Fix Warning: 'jj' may be used uninitialized [-Wmaybe-uninitialized]
mdtoyNOAA
approved these changes
Jun 30, 2025
barlage
approved these changes
Jul 1, 2025
haiqinli
approved these changes
Jul 1, 2025
BoYang-NOAA
approved these changes
Jul 8, 2025
Qingfu-Liu
approved these changes
Jul 8, 2025
|
All tests are done at ufs-community/ufs-weather-model#2790. @rhaesung @dustinswales @grantfirl can you merge this pr? |
rhaesung
pushed a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines many unrelated pieces of work. None of the changes are expected to change RT results.
Updating from latest NCAR/main fork/branch. The following PRs have already been merged there.
The following are new PRs into ufs/dev that are minor and don't change any RT results:
ECMWF non-stationary GWD (credit @BoYang-NOAA): Add ECMWF non-stationary gravity wave scheme option #273
bugfix for maxMF (credit @SamuelTrahanNOAA ): bug fix to maxMF check: only access when do_mynnedmf=.true. #283
NEPTUNE reproducibility bugfix (credit @areinecke and @climbfuji )Bug fix in radiation aerosols to fix restart reproducibility issue with NEPTUNE model #290
mersenne twister bugfix (credit @NickSzapiro-NOAA) : nrest=n+4 in mersenne_twister #292
compiler warning fixes (credit @NickSzapiro-NOAA): Tidy up more compiler warnings #297