Add sharding support to SMT #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child mode (for child aggregator in sharded setup) differs from normal mode (for monolithic aggregator) by taking a shard ID and using its most significant bit as the "path" for the root node to get the corrrect hash value for the corresponding node of the parent aggregator's SMT.
Parent mode (for parent aggregator in sharded setup) differs from normal mode (for monolithic aggregator) in three ways: - is allows values in leaves to be updated; - the leaves are not hashed (instead they contain hash values computed by and received from child aggregators); - to maintain fixed structure, the tree is really not sparse at all.
|
Note that this change breaks compatibility for client-side SDKs and probably should not be merged until the SDKs also have updates ready. |
jait91
approved these changes
Oct 21, 2025
Comment on lines
+676
to
+684
| // JoinPaths joins the hash proofs from a child and parent in sharded setting | ||
| func JoinPaths(child, parent *api.MerkleTreePath) (*api.MerkleTreePath, error) { | ||
| if len(child.Root) < 4 { | ||
| return nil, fmt.Errorf("invalid child root hash format") | ||
| } | ||
| if len(parent.Steps) == 0 { | ||
| return nil, fmt.Errorf("empty parent hash steps") | ||
| } | ||
| if parent.Steps[0].Data == nil || *parent.Steps[0].Data != child.Root[4:] { |
There was a problem hiding this comment.
maybe create a constant or add a comment what this 4 means
There was a problem hiding this comment.
Since we now use one hash function identifier for the whole inclusion proof, perhaps in fact better to extract it into a separate field and change the root hash into a plain hash value instead of keeping them merged into an imprint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An SMT can now be created in child, parent or normal mode.
Normal mode is for use in a monolithic (non-sharded) aggregator and behaves as before.
Child mode is for use in a child aggregator in sharded setup. Difference from normal mode:
Parent mode is for use in parent aggregator in sharded setup. Differences from normal mode: