Skip to content

Add sharding support to SMT #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Add sharding support to SMT #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
780b41d
Implement child mode for SMT
ahtotruu Oct 15, 2025
3ae7ad3
Implement parent mode for SMT
ahtotruu Oct 15, 2025
0eda03f
Inclusion proof improvements
ahtotruu Oct 16, 2025
f6d1ae8
Implement joining child and parent hash proofs for sharded setting
ahtotruu Oct 16, 2025
e97ead9
Fixed typos in tests
ahtotruu Oct 16, 2025
478b459
Usability: child SMT now takes full item path as key and strips the s…
ahtotruu Oct 17, 2025
a827fe7
Improved error handling in SMTs
ahtotruu Oct 17, 2025
f006e4d
Define separate type for shard IDs
ahtotruu Oct 17, 2025
6c0ed65
Small clean-up in tests
ahtotruu Oct 17, 2025
5f54ef9
Minor code clarification
ahtotruu Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/round/smt_persistence_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ func TestSmtPersistenceAndRestoration(t *testing.T) {

// Verify inclusion proofs work
for _, leaf := range testLeaves {
merkleTreePath := restoredRm.smt.GetPath(leaf.Path)
merkleTreePath, err := restoredRm.smt.GetPath(leaf.Path)
require.NoError(t, err)
require.NotNil(t, merkleTreePath, "Should be able to get Merkle path")
assert.NotEmpty(t, merkleTreePath.Root, "Merkle path should have root hash")
}
Expand Down Expand Up @@ -243,7 +244,8 @@ func TestCompleteWorkflowWithRestart(t *testing.T) {
path, err := commitment.RequestID.GetPath()
require.NoError(t, err, "Should be able to get path from request ID")

merkleTreePath := newRm.smt.GetPath(path)
merkleTreePath, err := newRm.smt.GetPath(path)
require.NoError(t, err)
require.NotNil(t, merkleTreePath, "Should be able to get Merkle path")
assert.NotEmpty(t, merkleTreePath.Root, "Merkle path should have root hash")
assert.NotEmpty(t, merkleTreePath.Steps, "Merkle path should have steps")
Expand Down
5 changes: 4 additions & 1 deletion internal/service/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,10 @@ func (as *AggregatorService) GetInclusionProof(ctx context.Context, req *api.Get
if err != nil {
return nil, fmt.Errorf("failed to get path for request ID %s: %w", req.RequestID, err)
}
merkleTreePath := as.roundManager.GetSMT().GetPath(path)
merkleTreePath, err := as.roundManager.GetSMT().GetPath(path)
if err != nil {
return nil, fmt.Errorf("failed to get inclusion proof for request ID %s: %w", req.RequestID, err)
}

// Find the latest block that matches the current SMT root hash
rootHash, err := api.NewHexBytesFromString(merkleTreePath.Root)
Expand Down
Loading