Skip to content

fix: updated _parse_query to use ivy's set_item to use get_item as it's optimized now#28582

Open
vedpatwardhan wants to merge 7 commits intounifyai:mainfrom
vedpatwardhan:set_item
Open

fix: updated _parse_query to use ivy's set_item to use get_item as it's optimized now#28582
vedpatwardhan wants to merge 7 commits intounifyai:mainfrom
vedpatwardhan:set_item

Conversation

@vedpatwardhan
Copy link
Copy Markdown
Contributor

No description provided.

@Ishticode
Copy link
Copy Markdown
Contributor

I've removed to_scalar call in _numel. This should be mostly fine but I am expecting ivy.pul_along_axis to fail as it uses _numel expecting it to be scalar for all backends. But will fix any other related changes. @vedpatwardhan

@vedpatwardhan
Copy link
Copy Markdown
Contributor Author

I've removed to_scalar call in _numel. This should be mostly fine but I am expecting ivy.pul_along_axis to fail as it uses _numel expecting it to be scalar for all backends. But will fix any other related changes. @vedpatwardhan

sounds good! Could you please make necessary changes to ivy.put_along_axis to get it fixed as well? Thanks @Ishticode 😄

…eturn a tensor by default if executing in graph mode to avoid breaking torch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants