lib-lua: Upgrade to Lua 5.4.8 #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade lib-lua to the latest upstream version 5.4.8. This includes updates to Library.uk, Makefile.uk, and related metadata. Verified to build and run successfully on Unikraft with musl C library.
craciunoiuc
requested changes
Jul 14, 2025
Member
craciunoiuc
left a comment
craciunoiuc
left a comment
There was a problem hiding this comment.
Left you some comments
Also it seems like you used the Unikraft user to commit?
Look into git config to configure your email from where you are committing
| homepage := "https://www.lua.org/" | ||
| license := "MIT" | ||
| version := 5.4.4 sha256:164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61 https://www.lua.org/ftp/lua-5.4.4.tar.gz | ||
| version := 5.4.8 sha256:164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61 https://www.lua.org/ftp/lua-5.4.8.tar.gz |
Member
There was a problem hiding this comment.
I think you need to change also the SHA here you can use sha256sum for that
|
|
||
| $(eval $(call fetch,liblua,$(LIBLUA_URL))) | ||
| $(eval $(call patch,liblua,$(LIBLUA_PATCHDIR),lua-$(LIBLUA_VERSION))) | ||
|
|
Member
There was a problem hiding this comment.
don't remove the newline here, it looked fine like that
Comment on lines
+1
to
+4
| menu "Library configuration" | ||
|
|
||
| config LIBLUA | ||
| bool "Lua scripting language" |
Member
There was a problem hiding this comment.
I understand the using of consistent indents but it needs to use menuconfig here to be in line with the other ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade lib-lua to the latest upstream version 5.4.8.
This includes updates to Library.uk, Makefile.uk, and related metadata. Verified to build and run successfully on Unikraft with musl C library.