Skip to content

lib-lua: Upgrade to Lua 5.4.8 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinavkumar1203 wants to merge 1 commit into
base: staging
Choose a base branch
from
+21 −14
Open

lib-lua: Upgrade to Lua 5.4.8 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions Config.uk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
menuconfig LIBLUA
bool "The Lua programming language"
default n
select LIBMUSL
select LIBUKTIME
select UKUNISTD
select LIBUKSIGNAL
menu "Library configuration"

config LIBLUA
bool "Lua scripting language"
Comment on lines +1 to +4
Copy link
Member

@craciunoiuc craciunoiuc Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the using of consistent indents but it needs to use menuconfig here to be in line with the other ones

default n
select LIBMUSL
select LIBUKTIME
select UKUNISTD
select LIBUKSIGNAL
help
The Lua scripting language library (v5.4.8).

if LIBLUA
config LIBLUA_MAIN_FUNCTION
bool "Provide main function"
default y
config LIBLUA_MAIN_FUNCTION
bool "Provide main function"
default y
help
Provide a default main() function.
endif

endmenu
4 changes: 2 additions & 2 deletions Library.uk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name := "lua"
name := "lib-lua"
description := "A powerful, efficient, lightweight, embeddable scripting language."
homepage := "https://www.lua.org/"
license := "MIT"
version := 5.4.4 sha256:164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61 https://www.lua.org/ftp/lua-5.4.4.tar.gz
version := 5.4.8 sha256:164c7849653b80ae67bec4b7473b884bf5cc8d2dca05653475ec2ed27b9ebf61 https://www.lua.org/ftp/lua-5.4.8.tar.gz
Copy link
Member

@craciunoiuc craciunoiuc Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to change also the SHA here you can use sha256sum for that

3 changes: 1 addition & 2 deletions Makefile.uk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@ $(eval $(call addlib_s,liblua,$(CONFIG_LIBLUA)))
################################################################################
# Sources
################################################################################
LIBLUA_VERSION=5.4.4
LIBLUA_VERSION=5.4.8
LIBLUA_TARBALL=lua-$(LIBLUA_VERSION)
LIBLUA_URL=https://www.lua.org/ftp/$(LIBLUA_TARBALL).tar.gz
LIBLUA_PATCHDIR=$(LIBLUA_BASE)/patches

$(eval $(call fetch,liblua,$(LIBLUA_URL)))
$(eval $(call patch,liblua,$(LIBLUA_PATCHDIR),lua-$(LIBLUA_VERSION)))

Copy link
Member

@craciunoiuc craciunoiuc Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove the newline here, it looked fine like that

################################################################################
# Helpers
################################################################################
Expand Down