debug : footer-line break issue #695
Conversation
wooseok123
changed the title
src/_css/main.css
Outdated
| @@ -224,6 +224,10 @@ hr { | |||
| align-items: flex-end; | |||
| } | |||
|
|
|||
| #footer nav { | |||
| font-size : 15px; | |||
There was a problem hiding this comment.
I'd prefer not adding a new font-size.
How about removing the dots . separators between the nav links and add margin-right: 0.5em for footer nav a?
There was a problem hiding this comment.
I agree with your opinion.
I've just added the modified version. (removing dots and adding margin-right to them, and things i had to do to align them in the right position.)
The line-break still remains in the mobile version, but i think it's not a big deal.
There was a problem hiding this comment.
And how about adding .prettierrc at the root of the project?
I've reset the initial commit because my local prettier settings had activated.
wooseok123
force-pushed
the
debug/footer-linebreak
branch
from
a9e9103
to
cf53671
Compare
Thanks! I'll open another PR about formatting :) |
|
@camillobruni If there aren’t any major issues, how about merging it? |
debug footer line break issue
issue : #694
changes :
margin-leftofdark-mode-toggle:1emto0.15emfont-sizeofnav:16pxto15pxI've changed
margin-leftvalue ofdark-mode-toggleto0.15emandfont-sizeof anchor tag in#footer navto15pxso that the letter 'light' and 'dark' can be in the same line until819px.The layout changes when the width is under
818px. So i think it would be better if there's no line break until819px.So it works on my code!
Before
(over
860px)After
(over
860px, it maintains the same line until819px)