Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug : footer-line break issue #695

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

debug : footer-line break issue #695

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bcfc6f
chore : change margin-left value
wooseok123 Apr 17, 2023
10062bd
Update main.css
wooseok123 Apr 17, 2023
1bc8d82
change the margin-left value
wooseok123 Apr 17, 2023
cf53671
Merge branch 'main' into debug/footer-linebreak
camillobruni Mar 24, 2024
5bebb39
fix css and remove seperator between links in footer
wooseok123 Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/_css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@ hr {
align-items: flex-end;
}

#footer nav {
font-size : 15px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not adding a new font-size.
How about removing the dots . separators between the nav links and add margin-right: 0.5em for footer nav a?

Copy link
Author

@wooseok123 wooseok123 Mar 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your opinion.
I've just added the modified version. (removing dots and adding margin-right to them, and things i had to do to align them in the right position.)

The line-break still remains in the mobile version, but i think it's not a big deal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how about adding .prettierrc at the root of the project?
I've reset the initial commit because my local prettier settings had activated.

}

pre, code, var, kbd, samp {
font-family: Source Code Pro, Monaco, Lucida Console, monospace;
font-size: 1em;
Expand Down Expand Up @@ -486,7 +490,7 @@ dark-mode-toggle {
--dark-mode-toggle-dark-icon: url(/_css/img/sun.svg);
--dark-mode-toggle-color: var(--main-and-footer-link-color);
--dark-mode-toggle-icon-filter: invert(80%);
margin-left: 1em;
margin-left: 0.15em;
position: relative;
top: 0.4rem;
}
Expand Down
Loading