H3INTRO: Use INTRORIM and preserve aspect ratio

[Alexander-Wilms]

Also fix glitches while resizing by using SDL_RenderClear()

introRim.mp4

[IvanSavenko]

Will it work for resolutions that are not 3x4, e.g HD/FullHD?

[Alexander-Wilms]

Not yet

[Alexander-Wilms]

Now all intro videos always have the correct aspect ratio.

[Alexander-Wilms]

When one has selected a widescreen resolution and resizes the window to have a narrower aspect ratio, black bars appear in both axes:

I'll try to address that as well.

[Alexander-Wilms]

Done

[Laserlicht]

Tested, looks good with keeping aspect ratio and rim. :)

[Alexander-Wilms]

I noticed it still breaks with a VCMI resolution of 1920x1080:

[Alexander-Wilms]

I tested it some more and noticed that it breaks when one changes the window size by dragging it to the left or right or top, not when one manually changes the window size.

Also, I can already reproduce a similar issue with the latest develop build (439ce11).

It seems like SDL doesn't get a usual resize event when one maximizes the window or sets it to half of the screen via the window manager.

This is all the same VCMI instance after resizing it by dragging it to the screen edges:

Maybe this issue combined with my code to use the actual window size instead of the resolution selected in the launcher results in the completely broken videos.

[Alexander-Wilms]

When I keep resizing the window using latest develop (1192dbf) I get the following:

[swscaler @ 0x55a4a3881fc0] Warning: data is not aligned! This can lead to a speed loss
Unable to create screen texture
Texture dimensions are limited to 16384x16384
terminate called after throwing an instance of 'std::runtime_error'
  what():  Unable to create screen texture
Abgebrochen (Speicherabzug geschrieben)

I started VCMi in windowed mode, reduced the window's height, dragged it to the top of the screen to maximize it, dragged it back and further reduced the window height. I repeated this a few times.

So it seems for the given intro video height of 600 px, a texture with a huge width is created that matches the ratio of the window. When it crashes the ratio is even higher than this:

[Alexander-Wilms]

I'll still need to add interface scaling for the intros.

[Alexander-Wilms]

Tested it with various resolutions, aspect ratios and interface scaling factors and it seems to work as expected.

Before merging, I'd remove the debug output, but keep it for now in case the MR still has to be adapted.

[Alexander-Wilms]

There are still issues on Android:

[Alexander-Wilms]

Now the intros work fine on desktop and Android: