feat!: rewrite react-vega #613
Conversation
domoritz
left a comment
domoritz
left a comment
There was a problem hiding this comment.
Awesome. Just a few comments but I think we are mostly good to merge and release.
|
Let me know when this is ready for a review. |
Ready for review 👍 @domoritz |
|
Please resolve the merge conflicts. Can we remove netlify then? |
domoritz
left a comment
domoritz
left a comment
There was a problem hiding this comment.
Thank you for the pull request! Just a few comments and then we can merge.
|
Will get around to addressing feedback this weekend, thanks for patience all! |
Co-authored-by: Dominik Moritz <[email protected]>
Co-authored-by: Dominik Moritz <[email protected]>
|
FYI I added husky back, it's just the easiest way to set up a pre-commit hook that I could find. We now run tsc, eslint, and prettier for each commit. Other than the outstanding comments that I've replied to, all other feedback should be addressed. Thanks for the patience again everybody. |
|
Can you resolve the merge conflicts? I am personally not a fan of precommit hooks. Let's remove them and instead add ci tests? |
domoritz
left a comment
domoritz
left a comment
There was a problem hiding this comment.
See my comment on ci linting
|
Removed husky and the pre-commit hook, updated the license, added linting in CI, and resolved merge conflicts. Let me know if there is anything else. |
5 participants
#612
TODO
It's been a while since I've published a npm package so it's very possible I'm missing something as it relates to that process. Ty in advanced for any feedback you may have :) cc @domoritz @kristw