-
-
Notifications
You must be signed in to change notification settings - Fork 72
feat!: rewrite react-vega #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c2c1b42
rewrite react-vega
JakeAdler 4558bd0
chore: add commitlint and test workflow
JakeAdler 200ef42
address feedback
JakeAdler 6da4fe6
Updated README and examples
JakeAdler d01f7d7
Update LICENSE
JakeAdler 7f32f6f
Update README.md
JakeAdler affb2a8
jest -> vitest + other feedback items
JakeAdler e7fd170
Add exports
JakeAdler 5b2e70d
remove pretty-quick
JakeAdler 9d973d2
add tsc to precommit hook
JakeAdler 61ba2ac
remove husky + update license
JakeAdler 296c3ab
Merge remote-tracking branch 'origin'
JakeAdler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
JakeAdler marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: "Publish Ladle Storybook" | ||
| on: | ||
| push: | ||
| branches: | ||
| - "main" | ||
|
|
||
| jobs: | ||
| publish-storybook: | ||
| permissions: | ||
| id-token: "write" | ||
| pages: "write" | ||
|
|
||
| environment: | ||
| name: "github-pages" | ||
| url: "${{ steps.deployment.outputs.page_url }}" | ||
|
|
||
| runs-on: "ubuntu-latest" | ||
| steps: | ||
| - id: "checkout" | ||
| name: "Check out Git repository" | ||
| uses: "actions/checkout@v4" | ||
|
|
||
| - id: "setup-node" | ||
| name: "Set up Node.js" | ||
| uses: "actions/setup-node@v4" | ||
|
|
||
| - id: "install-dependencies" | ||
| name: "Install Node.js dependencies" | ||
| run: npm install | ||
|
|
||
| - id: "build" | ||
| name: "Build Ladle Storybook" | ||
| run: | | ||
| npm run build | ||
| npm run build-demo | ||
|
|
||
| - id: "upload-storybook" | ||
| name: "Upload Pages artifact" | ||
| uses: "actions/upload-pages-artifact@v3" | ||
| with: | ||
| path: "storybook/" | ||
|
|
||
| - id: "deployment" | ||
| name: "Deploy Storybook to GitHub Pages" | ||
| uses: "actions/deploy-pages@v4" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,18 @@ | ||
| name: Build and test | ||
| name: Node.js CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| on: [push] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Use Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.10 | ||
| cache: 'yarn' | ||
| - name: Install dependencies | ||
| run: yarn install | ||
| - name: Build | ||
| run: yarn build | ||
| - name: Test | ||
| run: yarn test | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/[email protected] | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.x' | ||
JakeAdler marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - run: npm ci | ||
| - run: npm run build | ||
| - run: npm test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,30 @@ | ||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
|
|
||
| # Directory for instrumented libs generated by jscoverage/JSCover | ||
| lib-cov | ||
|
|
||
| # node-waf configuration | ||
| .lock-wscript | ||
|
|
||
| # Misc | ||
| .env | ||
| Dockerfile | ||
| docker-compose.yml | ||
|
|
||
| .DS_Store | ||
| *.DS_Store | ||
| *.sublime-workspace | ||
|
|
||
| # Logs | ||
| logs/ | ||
| logs | ||
| *.log | ||
| *.tsbuildinfo | ||
|
|
||
| # Cache | ||
| tmp | ||
| .publish | ||
| .sass-cache | ||
| .bundle/ | ||
| .happo/ | ||
| .idea/ | ||
| .next/ | ||
| .cache | ||
| .eslintcache | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| storybook | ||
| coverage | ||
| dist-ssr | ||
| *.local | ||
|
|
||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .npm | ||
| .vscode | ||
| .yarnclean | ||
|
|
||
| # Directories | ||
| build/ | ||
| coverage/ | ||
| dist/ | ||
| esm/ | ||
| lib/ | ||
| public/ | ||
| node_modules/ | ||
| tmp/ | ||
|
|
||
| # Custom | ||
| *.map | ||
| *.min.js | ||
| test-changelog.md | ||
|
|
||
| # Lock files, libs should not have lock files | ||
| npm-shrinkwrap.json | ||
| package-lock.json | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? | ||
|
|
||
| # Storybook output | ||
| *storybook.log | ||
| storybook-static |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| yarn commitlint --edit "$1" | ||
| npm run commitlint $1 | ||
JakeAdler marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| yarn lint-staged | ||
| npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| /** @type {import('@ladle/react').UserConfig} */ | ||
JakeAdler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export default { | ||
| outDir: "storybook", | ||
| base: "/react-vega/", | ||
| viteConfig: "vite.config.demo.ts", | ||
| expandStoryTree: true, | ||
| }; | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.