Wire telemetry into the framework#195
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
msullivan
approved these changes
Jul 9, 2026
Comment on lines
+719
to
+725
| if res.results: | ||
| data.result = res.results[0].result | ||
| data.is_error = any(p.is_error for p in res.results) | ||
| # A tool exception is caught and converted to an error | ||
| # result before it reaches this block, so it never hits the | ||
| # span's own except path — thread it through explicitly. | ||
| sp.error = res.exception |
Contributor
There was a problem hiding this comment.
Sigh, filling in the data object like this after already creating it and passing it to the span does seem pretty ugly to me, now that I look at it.
It's better than otel's sp.add_attribute("result", res.results[0].result) but I think that needing to save data to a variable and then updating it there and depending on the span holding a reference to it instead of making a copy is a little smelly.
I added https://github.com/vercel-labs/ai-python/pull/194/changes#r3548140961 comment based on this thought. I think we should make that improvement but we don't actually need to update this PR to fully take advantage of it right now.
Co-authored-by: Michael J. Sullivan <sully@msully.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instruments the framework using the telemetry system implemented in #194 .