-
Notifications
You must be signed in to change notification settings - Fork 12
Wire telemetry into the framework #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3784d99
Wire telemetry into the framework
anbuzin d9a302d
Fix the early interruption issue
anbuzin d3e3c2c
Remove the lying turn index
anbuzin 6221a23
Move telemetry example from the top level
anbuzin 1294e51
Apply suggestions from code review
anbuzin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| """Agent run with telemetry: console adapter + a custom span in a tool. | ||
|
|
||
| For an out-of-process viewer, run ``python -m ai.telemetry.utils.viewer`` | ||
| and see ``ai/telemetry/utils/viewer.py`` for the otel exporter setup. | ||
| """ | ||
|
|
||
| import asyncio | ||
|
|
||
| import ai | ||
| from ai.telemetry.utils import console | ||
|
|
||
|
|
||
| @ai.tool | ||
| async def get_weather(city: str) -> str: | ||
| """Get current weather for a city.""" | ||
| async with ai.telemetry.span("lookup", city=city) as span: | ||
| await asyncio.sleep(0.1) | ||
| span.set(source="cache") | ||
| return f"Sunny, 72F in {city}" | ||
|
|
||
|
|
||
| async def main() -> None: | ||
| ai.telemetry.register(console.ConsoleAdapter()) | ||
|
|
||
| model = ai.get_model("anthropic/claude-sonnet-4.6") | ||
| my_agent = ai.Agent(tools=[get_weather]) | ||
| messages = [ai.user_message("What's the weather in Tokyo?")] | ||
|
|
||
| async with my_agent.run(model, messages) as stream: | ||
| async for _ in stream: | ||
| pass | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| asyncio.run(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, filling in the data object like this after already creating it and passing it to the span does seem pretty ugly to me, now that I look at it.
It's better than otel's
sp.add_attribute("result", res.results[0].result)but I think that needing to savedatato a variable and then updating it there and depending on the span holding a reference to it instead of making a copy is a little smelly.I added https://github.com/vercel-labs/ai-python/pull/194/changes#r3548140961 comment based on this thought. I think we should make that improvement but we don't actually need to update this PR to fully take advantage of it right now.