refactor(turbopack): Rewrite CollectiblesSource callsites to use OperationVc (part 1/3) #74051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
This was referenced Dec 18, 2024
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| buildDuration | 17.8s | 16.3s | N/A |
| buildDurationCached | 15.4s | 13s | N/A |
| nodeModulesSize | 416 MB | 416 MB | ✓ |
| nextStartRea..uration (ms) | 459ms | 480ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| 1187-HASH.js gzip | 52.4 kB | 52.4 kB | N/A |
| 8276.HASH.js gzip | 169 B | 168 B | N/A |
| 8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
| bccd1874-HASH.js gzip | 52.8 kB | 52.8 kB | N/A |
| framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
| main-app-HASH.js gzip | 232 B | 235 B | N/A |
| main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 193 B | 193 B | ✓ |
| amp-HASH.js gzip | 512 B | 510 B | N/A |
| css-HASH.js gzip | 343 B | 342 B | N/A |
| dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
| edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
| head-HASH.js gzip | 363 B | 362 B | N/A |
| hooks-HASH.js gzip | 393 B | 392 B | N/A |
| image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
| index-HASH.js gzip | 268 B | 268 B | ✓ |
| link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
| routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
| script-HASH.js gzip | 397 B | 397 B | ✓ |
| withRouter-HASH.js gzip | 323 B | 326 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 749 B | 746 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| index.html gzip | 522 B | 524 B | N/A |
| link.html gzip | 537 B | 537 B | ✓ |
| withRouter.html gzip | 518 B | 520 B | N/A |
| Overall change | 537 B | 537 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 129 kB | 129 kB | N/A |
| page.js gzip | 206 kB | 206 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 670 B | 666 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
| edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
| Overall change | 844 B | 844 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| 274-experime...dev.js gzip | 322 B | 322 B | ✓ |
| 274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
| app-page-exp...dev.js gzip | 359 kB | 359 kB | ✓ |
| app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
| app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
| app-page-tur..prod.js gzip | 137 kB | 137 kB | ✓ |
| app-page.run...dev.js gzip | 348 kB | 348 kB | ✓ |
| app-page.run..prod.js gzip | 125 kB | 125 kB | ✓ |
| app-route-ex...dev.js gzip | 37.4 kB | 37.4 kB | ✓ |
| app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
| app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
| app-route-tu..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
| app-route.ru...dev.js gzip | 39.1 kB | 39.1 kB | ✓ |
| app-route.ru..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
| pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
| pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
| pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
| pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
| server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
| Overall change | 2.44 MB | 2.44 MB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js bgw/operationvc-collectibles-migration-pt1 | Change | |
|---|---|---|---|
| 0.pack gzip | 2.08 MB | 2.08 MB | |
| index.pack gzip | 73.6 kB | 74.2 kB | |
| Overall change | 2.16 MB | 2.16 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
bgw
changed the title
sokra
approved these changes
Dec 19, 2024
bgw
force-pushed
the
bgw/state-requires-operation-value
branch
from
631ff59 to
e6b66e1
Compare
bgw
force-pushed
the
bgw/operationvc-collectibles-migration-pt1
branch
from
d2e22bf to
d376e51
Compare
bgw
commented
Dec 20, 2024
Comment on lines
+254
to
+256
| // we already assume `result_op`'s value here because we're called inside of a match arm, but | ||
| // await `result_op` anyways, so that if it generates any collectible issues, they're captured | ||
| // here. |
There was a problem hiding this comment.
This is a change in behavior (the old version didn't pass through an operation/collectibles), but that seems like a mistake?
bgw
force-pushed
the
bgw/state-requires-operation-value
branch
2 times, most recently
from
c6fe120 to
7aa49a6
Compare
bgw
force-pushed
the
bgw/operationvc-collectibles-migration-pt1
branch
from
d376e51 to
f1cac49
Compare
bgw
changed the title
bgw
changed the base branch from
bgw/state-requires-operation-value
to
graphite-base/74051
bgw
force-pushed
the
graphite-base/74051
branch
from
7aa49a6 to
afddbe7
Compare
bgw
force-pushed
the
bgw/operationvc-collectibles-migration-pt1
branch
2 times, most recently
from
784f935 to
292013c
Compare
bgw
force-pushed
the
bgw/operationvc-collectibles-migration-pt1
branch
from
292013c to
9a73684
Compare
Merge activity
|
This was referenced Jan 3, 2025
refactor(turbopack/next-api): Implement NonLocalValue for TracedDiGraph and SingleModuleGraph
#74506
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperationVcs should be used withCollectiblesSourceinstead ofVcs because collectibles represent a side-effect or implicit extra return value of a function's execution.This PR doesn't convert all callsites, just a handful.
Closes PACK-3677