refactor(turbopack-core): Use ResolvedVc for IntrospectableModule and IntrospectableSource - #74512
Merged
Merged
Conversation
This was referenced Jan 4, 2025
Merged
This was referenced Jan 4, 2025
Merged
refactor(turbopack/next-api): Implement NonLocalValue for TracedDiGraph and SingleModuleGraph
#74506
Merged
Member
Author
This was referenced Jan 4, 2025
Merged
bgw
marked this pull request as ready for review
January 4, 2025 01:07
Member
Tests Passed |
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| buildDuration | 41.9s | 37.2s | N/A |
| buildDurationCached | 35.7s | 32.1s | N/A |
| nodeModulesSize | 418 MB | 418 MB | ✓ |
| nextStartRea..uration (ms) | 964ms | 1s | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| 5306-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
| 8276.HASH.js gzip | 169 B | 168 B | N/A |
| 8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
| bccd1874-HASH.js gzip | 53 kB | 53 kB | ✓ |
| framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
| main-app-HASH.js gzip | 240 B | 242 B | N/A |
| main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
| Overall change | 53 kB | 53 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 193 B | 193 B | ✓ |
| amp-HASH.js gzip | 512 B | 510 B | N/A |
| css-HASH.js gzip | 343 B | 342 B | N/A |
| dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
| edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
| head-HASH.js gzip | 363 B | 362 B | N/A |
| hooks-HASH.js gzip | 393 B | 392 B | N/A |
| image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
| index-HASH.js gzip | 268 B | 268 B | ✓ |
| link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
| routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
| script-HASH.js gzip | 397 B | 397 B | ✓ |
| withRouter-HASH.js gzip | 323 B | 326 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 749 B | 747 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| index.html gzip | 523 B | 523 B | ✓ |
| link.html gzip | 538 B | 537 B | N/A |
| withRouter.html gzip | 519 B | 520 B | N/A |
| Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 128 kB | 128 kB | N/A |
| page.js gzip | 207 kB | 207 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 669 B | 671 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
| edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
| Overall change | 844 B | 844 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| 274-experime...dev.js gzip | 322 B | 322 B | ✓ |
| 274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
| app-page-exp...dev.js gzip | 368 kB | 368 kB | ✓ |
| app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
| app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
| app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
| app-page.run...dev.js gzip | 355 kB | 355 kB | ✓ |
| app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
| app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
| app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
| app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
| app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
| app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
| app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
| pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
| pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
| pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
| pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
| server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
| Overall change | 2.46 MB | 2.46 MB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js bgw/resolved-introspectable-module-and-source | Change | |
|---|---|---|---|
| 0.pack gzip | 2.09 MB | 2.1 MB | |
| index.pack gzip | 75.6 kB | 75.2 kB | N/A |
| Overall change | 2.09 MB | 2.1 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
kdy1
approved these changes
Jan 4, 2025
bgw
force-pushed
the
bgw/resolved-process-result
branch
from
January 6, 2025 20:03
3f4d0cc to
e1a4092
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 6, 2025 20:03
6d969e6 to
cfef664
Compare
bgw
force-pushed
the
bgw/resolved-process-result
branch
from
January 8, 2025 22:47
e1a4092 to
83eba5d
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 8, 2025 22:47
cfef664 to
e8bc4e5
Compare
bgw
force-pushed
the
bgw/resolved-process-result
branch
from
January 9, 2025 00:37
83eba5d to
af41f22
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 00:38
e8bc4e5 to
df0df8c
Compare
bgw
force-pushed
the
bgw/resolved-process-result
branch
from
January 9, 2025 05:56
af41f22 to
162cd25
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 05:57
df0df8c to
a478323
Compare
bgw
force-pushed
the
bgw/resolved-process-result
branch
from
January 9, 2025 17:00
162cd25 to
bd8bb7f
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 17:01
a478323 to
2d0edf9
Compare
bgw
force-pushed
the
bgw/resolved-process-result
branch
2 times, most recently
from
January 9, 2025 18:10
7124286 to
40d14cf
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 18:10
2d0edf9 to
ef686e3
Compare
bgw
changed the base branch from
bgw/resolved-process-result
to
graphite-base/74512
January 9, 2025 19:07
bgw
force-pushed
the
graphite-base/74512
branch
from
January 9, 2025 19:07
40d14cf to
a0eab62
Compare
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 19:07
ef686e3 to
2fa29a9
Compare
… IntrospectableSource
bgw
force-pushed
the
bgw/resolved-introspectable-module-and-source
branch
from
January 9, 2025 19:08
2fa29a9 to
9a70357
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PACK-3699