-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blob): Provide onUploadProgress({ loaded, total, percentage }) #782
Merged
+2,432
−895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an `onUploadProgress` callback to put/upload*. Since we're using fetch, this works by making sure every body we send via fetch is a ReadableStream (web). Once it's a ReadableStream we can follow its consumption. Caveats: - This only measures what gets sent to the server, not what was received by the server - Safari & Firefox are not supporting bodies as ReadableStreams, we may need to introduce.. xhr! TODO: - [] Add XHR fallback for runtimes not supporting streams as bodies but having XHR - [] Add real browser tests ensuring we get multiple onUploadProgress events for big files - [] Ensure we send one event at the start of the upload (progress: 0)
🦋 Changeset detectedLatest commit: 682d4ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vvo
commented
Oct 24, 2024
luismeyer
requested changes
Oct 24, 2024
Co-authored-by: Luis Meyer <[email protected]>
…o feat/blob/on-progress
luismeyer
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an
onUploadProgress
callback to put/upload*. Here's how to use it:How does it work?
By default we use
fetch
. When you passonUploadProgress
, we turn the file into a stream to track the stream consumption's progress by fetch.For browsers not supporting
fetch
with streams (Safari, Firefox), we useXMLHttpRequest
and its progress events.This means we re-implemented parts of https://github.com/axios/axios or other fetch libraries using xhr as backup. But remember, progress events are somehow lying as they only measure what gets sent from your computer to the server, not what the server really acknowledged. Still, they are a good indicator for progress of the upload.