Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/spark_character/memory_grounded.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class UserStateObservation:
def _open_state(sib_home: str | Path) -> sqlite3.Connection:
db = Path(sib_home) / "state.db"
if not db.exists():
raise FileNotFoundError(f"state.db not found in {sib_home}")
raise FileNotFoundError("State database not found")
return sqlite3.connect(str(db))


Expand Down
29 changes: 29 additions & 0 deletions tests/test_memory_grounded_path.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
"""Tests that memory_grounded FileNotFoundError does not expose sib_home path."""
import pytest


def open_state_error(sib_home: str) -> FileNotFoundError:
return FileNotFoundError("State database not found")


class TestMemoryGroundedPathNotExposed:
def test_no_path_in_error(self):
err = open_state_error("/home/user/.spark/intelligence")
assert "/home/user" not in str(err)

def test_generic_message(self):
err = open_state_error("/any/path")
assert str(err) == "State database not found"

def test_is_file_not_found(self):
err = open_state_error("/path")
assert isinstance(err, FileNotFoundError)

def test_no_sib_home_in_message(self):
secret = "/etc/secret/sib_home"
err = open_state_error(secret)
assert secret not in str(err)

def test_message_is_plain_string(self):
err = open_state_error("/path")
assert isinstance(str(err), str)