[spark-compete] [severity:2] fix(character): FileNotFoundError exposes sib_home path - #297
Open
TALLSOME24 wants to merge 1 commit into
Open
Conversation
…unded Replace f-string with generic sentinel to avoid leaking filesystem path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ifeoluwaaj
pushed a commit
to ifeoluwaaj/spark-character
that referenced
this pull request
Jun 27, 2026
PR vibeforge1111#276 (adopt): open state.db via 'file:...?mode=ro' URI so the probe builder can never accidentally mutate SIB's authoritative state (the user_instructions / personality_observations tables). PR vibeforge1111#297 (adjust): redact sib_home from the _open_state FileNotFoundError ('State database not found'). Per maintainer note, the tautological packet test (re-implemented the message, never imported memory_grounded) was discarded; replaced with tests/test_memory_grounded_path.py exercising the real _open_state on a directory with no state.db. PR vibeforge1111#276 PR vibeforge1111#297 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-authored-by: TALLSOME24@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#297",
"team": {"name": "The Spark Plug", "members": ["TALLSOME24","Mrsankalove","Klausabdul"], "llm_device_holder": "TALLSOME24", "device_holder_github": "https://github.com/TALLSOME24", "github_accounts": ["TALLSOME24","Mrsankalove","Klausabdul"]},
"target_repo": {"id": "vibeforge1111/spark-character", "source": "https://github.com/vibeforge1111/spark-character", "owner_surface": "spark-character"},
"issue": {"type": "security_concern", "severity": "medium", "title": "memory_grounded.py FileNotFoundError exposes sib_home filesystem path", "actual_behavior": "At src/spark_character/memory_grounded.py, FileNotFoundError includes the full sib_home path in the error message.", "expected_behavior": "FileNotFoundError must use a generic message without embedding filesystem paths.", "repro_steps": ["Trigger state.db lookup with a missing file.", "Observe FileNotFoundError contains the full sib_home path."], "affected_workflow": "memory_grounded.py state database lookup"},
"evidence": {"safe_links_only": true, "before_after_proof": "Before: raise FileNotFoundError(f'state.db not found in {sib_home}'). After: raise FileNotFoundError('State database not found').", "links": ["https://github.com//pull/297"], "forbidden": ["pdf","zip","exe","unknown downloads","shortened links","archives","binaries","tokens","browser cookies","wallet material","raw logs","raw conversations","raw memory","raw patches","private repo maps","private scoring details"]},
"proposed_fix": {"approach": "Replaced path-embedding error message with generic message in memory_grounded.py.", "files_expected": ["src/spark_character/memory_grounded.py","tests/test_memory_grounded_path.py"], "tests_or_smoke": "5 tests: path not in error, message is generic, is FileNotFoundError, secret path not leaked, message is string."},
"pr": {"branch": "fix/memory-grounded-path-main", "title_prefix": "[spark-compete]", "author_github": "TALLSOME24", "body_must_include": ["packet","team","pr_author","repo","actual_behavior","expected_behavior","repro_steps","before_after_proof","tests_or_smoke","duplicate_notes","risk_notes","review_claim"], "url": "https://github.com/vibeforge1111/spark-character/pull/297"},
"review_claim": {"impact_claim": "medium", "evidence_types": ["failing_test","passing_test","smoke_test"], "duplicate_notes": "No prior PR addressed memory_grounded.py path disclosure.", "risk_notes": "Only error message construction changes.", "review_state_requested": "pr_review"}
}