[spark-compete] [severity:2] fix(character): FileNotFoundError exposes full artifact path - #298
Open
TALLSOME24 wants to merge 1 commit into
Conversation
…na.py Replace f-string with generic sentinel to avoid leaking filesystem path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ifeoluwaaj
pushed a commit
to ifeoluwaaj/spark-character
that referenced
this pull request
Jun 27, 2026
Consolidated path-redaction across the character runtime's FileNotFoundError / ValueError messages so callers no longer learn the internal directory layout. PR vibeforge1111#287 (Esc1200, adopt): drop the full path from critic.load_critic and the base-chip YAML filename from registry.promote_evolved_persona_to_chip_lab. PR vibeforge1111#286 (Esc1200, adjust; same-author same-concern as vibeforge1111#287 -> one band): drop the search-path list from chip_loader.load_chip_by_id and replace the absolute artifact paths in persona.set_latest_persona_version / load_persona with the bare filename. Per maintainer note, also redact persona.load_persona_from_path (line 203) to the filename for consistency; the chip id / artifact filename are retained because they aid debugging. PR vibeforge1111#298 (TALLSOME24, adjust): set_latest_persona_version line redaction. Per maintainer note the tautological packet test (re-implemented the message, never imported persona) was discarded; replaced with tests/test_persona_artifact_path.py exercising the real set_latest_persona_version against a missing artifact. The bundled packet-chip-loader-path-leak.json from vibeforge1111#286 was excluded. PR vibeforge1111#287 PR vibeforge1111#286 PR vibeforge1111#298 Co-authored-by: Esc1200@users.noreply.github.com Co-authored-by: TALLSOME24@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#298",
"team": {"name": "The Spark Plug", "members": ["TALLSOME24","Mrsankalove","Klausabdul"], "llm_device_holder": "TALLSOME24", "device_holder_github": "https://github.com/TALLSOME24", "github_accounts": ["TALLSOME24","Mrsankalove","Klausabdul"]},
"target_repo": {"id": "vibeforge1111/spark-character", "source": "https://github.com/vibeforge1111/spark-character", "owner_surface": "spark-character"},
"issue": {"type": "security_concern", "severity": "medium", "title": "persona.py FileNotFoundError exposes full artifact filesystem path", "actual_behavior": "At src/spark_character/persona.py, FileNotFoundError includes the full artifact_path in the error message.", "expected_behavior": "FileNotFoundError must use a generic message without embedding filesystem paths.", "repro_steps": ["Trigger persona artifact lookup with a missing file.", "Observe FileNotFoundError contains the full artifact_path."], "affected_workflow": "persona.py artifact file lookup"},
"evidence": {"safe_links_only": true, "before_after_proof": "Before: raise FileNotFoundError(f'Persona artifact not found: {artifact_path}'). After: raise FileNotFoundError('Persona artifact not found').", "links": ["https://github.com//pull/298"], "forbidden": ["pdf","zip","exe","unknown downloads","shortened links","archives","binaries","tokens","browser cookies","wallet material","raw logs","raw conversations","raw memory","raw patches","private repo maps","private scoring details"]},
"proposed_fix": {"approach": "Replaced path-embedding error message with generic message in persona.py.", "files_expected": ["src/spark_character/persona.py","tests/test_persona_artifact_path.py"], "tests_or_smoke": "5 tests: path not in error, message is generic, is FileNotFoundError, secret path not leaked, message is string."},
"pr": {"branch": "fix/persona-artifact-path-main", "title_prefix": "[spark-compete]", "author_github": "TALLSOME24", "body_must_include": ["packet","team","pr_author","repo","actual_behavior","expected_behavior","repro_steps","before_after_proof","tests_or_smoke","duplicate_notes","risk_notes","review_claim"], "url": "https://github.com/vibeforge1111/spark-character/pull/298"},
"review_claim": {"impact_claim": "medium", "evidence_types": ["failing_test","passing_test","smoke_test"], "duplicate_notes": "No prior PR addressed persona.py artifact path disclosure.", "risk_notes": "Only error message construction changes.", "review_state_requested": "pr_review"}
}