Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow examine_env to load hard coded policies #87

Merged
merged 3 commits into from
May 1, 2023
Merged

Conversation

palanc
Copy link
Collaborator

@palanc palanc commented May 1, 2023

Example command:
python robohive/utils/examine_env.py -e FrankaReachRandom-v0 -p robohive.utils.examine_env.rand_policy

Patrick Lancaster added 2 commits May 1, 2023 12:23
…utils/examine_env.py -e FrankaReachRandom-v0 -p robohive.utils.examine_env.rand_policy
Copy link
Owner

@vikashplus vikashplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Lets update the DESC to document this use case
  2. Lets add an example as well to show the usage
  3. Lets update the tests/test_examine_env.py to add a unit test
  4. Lets update the wiki/tutorial to add a use case (I can do this)

@palanc
Copy link
Collaborator Author

palanc commented May 1, 2023

Addressed points 1-3. For point 2, could show an example of policy that is not completely random and is likely to succeed once #89 is merged

@vikashplus vikashplus merged commit 1a8bc83 into dev May 1, 2023
@vikashplus vikashplus deleted the script_policy_load branch May 1, 2023 19:37
vikashplus pushed a commit that referenced this pull request Aug 31, 2023
* Allow examine_envs to load hard coded policies, E.g.
python robohive/utils/examine_env.py -e FrankaReachRandom-v0 -p robohive.utils.examine_env.rand_policy

* Remove unnecessary import
* examine_env loading scripted polcies: update DESC in examine_env and add unit test
Co-authored-by: Patrick Lancaster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants