feat(tui): Settings screen read/edit bosun.config.json fields inline with validation by jaeko44 · Pull Request #439 · virtengine/bosun

jaeko44 · 2026-03-25T18:42:28Z

Task-ID: 3ad65810-1698-452e-91e0-ffc3822728d0\n\nAutomated PR for task 3ad65810-1698-452e-91e0-ffc3822728d0

github-actions · 2026-03-25T18:42:43Z

Bosun CI signal: Bosun-created PR currently has failing checks.

Automation scope: Bosun-created
Workflow: CI
Conclusion: failure
Run: https://github.com/virtengine/bosun/actions/runs/23598711389
Head SHA: 20e3d81
Failed jobs: Build + Tests

Copilot

Pull request overview

Adds a new Ink-based TUI “Settings” screen intended to edit bosun.config.json inline (schema-driven) with AJV validation, and attempts to trigger runtime config reloads after saves.

Changes:

Introduces ui/tui/SettingsScreen.js to flatten bosun.schema.json, render grouped fields, edit values, validate, and persist changes.
Adds a process-local config-events emitter/listener and wires the Settings tab to render the new screen.
Adds/updates tests for the Settings screen and attempts to hook monitor reload behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
ui/tui/constants.js	Removes the `figures` dependency usage by swapping to an empty `figures` object with fallbacks.
ui/tui/config-events.js	Adds a globalThis-backed EventEmitter for `config-reload` events.
ui/tui/SettingsScreen.js	New Settings screen: schema flattening, inline editing, AJV validation, atomic write, emits reload event.
ui/tui/App.js	Wires Settings tab to SettingsScreen; refactors some tab rendering (including Logs).
tests/tui/settings-screen.test.mjs	Adds SettingsScreen tests using Ink test harness (currently schema-mismatched assertions).
tests/tui-settings-screen.test.mjs	Adds another SettingsScreen test file (overlapping intent; also schema-mismatched).
infra/monitor.mjs	Attempts to listen for config reload events and call `reloadConfig` (currently contains invalid injected `r`n sequences).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T18:49:34Z

tests/tui-settings-screen.test.mjs

+  const originalEnv = process.env;
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.KANBAN_BACKEND;
+    delete process.env.TELEGRAM_UI_PORT;
+    delete process.env.TELEGRAM_BOT_TOKEN;
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+    vi.restoreAllMocks();


originalEnv is captured as a reference (const originalEnv = process.env) and later restored via process.env = originalEnv, which can reintroduce mutations from other tests. Use the repo’s common pattern of snapshotting (const originalEnv = { ...process.env }) and restoring with a shallow copy in afterEach/beforeEach.

Copilot · 2026-03-25T18:49:35Z

tests/tui-settings-screen.test.mjs

+  it("renders grouped config fields with masked secrets and source labels", async () => {
+    process.env.TELEGRAM_BOT_TOKEN = "env-token";
+
+    const { dir } = createConfigDir({
+      kanban: { backend: "github" },
+      telegram: { uiPort: 3080, token: "config-token" },
+      costRates: { inputPer1M: 1.5 },
+    });
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, {
+        configDir: dir,
+        config: { kanban: { backend: "github" }, telegram: { uiPort: 3080, token: "config-token" }, costRates: { inputPer1M: 1.5 } },
+      }),
+      { columns: 220, rows: 60 },
+    );
+
+    const text = view.text();
+    expect(text).toContain("General");
+    expect(text).toContain("Kanban");
+    expect(text).toContain("Integrations");
+    expect(text).toContain("Cost Rates");
+    expect(text).toContain("backend");
+    expect(text).toContain("github");
+    expect(text).toContain("from config");
+    expect(text).toContain("from env");
+    expect(text).toContain("****");
+    expect(text).not.toContain("env-token");
+


This test expects schema-driven fields like telegram.uiPort / telegram.token and costRates.*, but bosun.schema.json does not define a telegram object or costRates, so SettingsScreen won’t render these rows and waitFor(() => view.text().includes("uiPort: 3080")) will time out. Update the test to use fields that exist in the schema (e.g., cloudflareDnsMaxRetries, kanban.backend, kanban.github.project.webhook.secret, etc.) and the correct env var names.

Copilot · 2026-03-25T18:49:35Z

infra/monitor.mjs

 } from "../task/task-store.mjs";
 import { createAgentEndpoint } from "../agent/agent-endpoint.mjs";
-import { createAgentEventBus } from "../agent/agent-event-bus.mjs";
+import { createAgentEventBus } from "../agent/agent-event-bus.mjs";`r`nimport { onConfigReload } from "../ui/tui/config-events.js";


The new import line contains literal rncharacters (likely from an escaped CRLF) which makes the file invalid JavaScript. Split this into a normal standaloneimport { onConfigReload ... }` statement on its own line and remove the stray characters/backticks.

Suggested change

import { createAgentEventBus } from "../agent/agent-event-bus.mjs";`r`nimport { onConfigReload } from "../ui/tui/config-events.js";

import { createAgentEventBus } from "../agent/agent-event-bus.mjs";

import { onConfigReload } from "../ui/tui/config-events.js";

Copilot · 2026-03-25T18:49:35Z

infra/monitor.mjs

+process.on("exit", () => {`r`n  try { stopTuiConfigReloadListener?.(); } catch { /* best effort */ }
  shuttingDown = true;


The exit handler line is missing proper newlines/bracing and includes stray rntext, leaving the handler body unterminated. Format the handler as a normal multi-line function and ensurestopTuiConfigReloadListener()` is called inside a try/finally (or best-effort try/catch) without breaking the rest of the shutdown logic.

Copilot · 2026-03-25T18:49:36Z

ui/tui/SettingsScreen.js

+function atomicWriteJson(path, config) {
+  const tempPath = `${path}.tmp`;
+  writeFileSync(tempPath, `${JSON.stringify(config, null, 2)}\n`, "utf8");
+  renameSync(tempPath, path);
+}


atomicWriteJson uses renameSync(tempPath, path) without any fallback/cleanup. On Windows (and some network filesystems) rename can fail when the destination exists or is locked, leaving the .tmp file behind. Follow the repo’s existing atomic-write pattern (tmp + rename with fallback to direct write/copy + best-effort temp cleanup).

Copilot · 2026-03-25T18:49:37Z

ui/tui/config-events.js

+
+export function emitConfigReload(payload = {}) {
+  bus.emit("config-reload", payload);


This event bus is process-local (globalThis + EventEmitter), so emitConfigReload() from the TUI won’t reach the running monitor/ui-server process (which is a separate Node process). If the intent is to reload runtime config when SettingsScreen saves, this needs to go over an IPC boundary (e.g., a WebSocket command/event to the server/monitor, a REST endpoint, or a file watcher in the monitor), not an in-memory emitter.

Suggested change

export function emitConfigReload(payload = {}) {

bus.emit("config-reload", payload);

/**

* Attempt to notify a parent/monitor process about a config reload over IPC.

* This uses Node's built-in `process.send` when an IPC channel is available

* (e.g., when this process was spawned with the `ipc` stdio option).

*/

function sendConfigReloadIPC(payload) {

if (typeof process !== "undefined" && typeof process.send === "function") {

try {

process.send({ type: "config-reload", payload });

} catch {

// Swallow IPC errors to avoid breaking local event emission.

}

}

}

export function emitConfigReload(payload = {}) {

// Notify listeners within this process.

bus.emit("config-reload", payload);

// Also attempt to notify any parent/monitor process over IPC.

sendConfigReloadIPC(payload);

Copilot · 2026-03-25T18:49:37Z

tests/tui-settings-screen.test.mjs

+  return JSON.parse(readFileSync(path, "utf8"));
+}
+
+describe("tui settings screen", () => {


There are now two separate SettingsScreen test files (tests/tui/settings-screen.test.mjs and tests/tui-settings-screen.test.mjs) that largely overlap in intent. Consider consolidating into one location/pattern to avoid redundant coverage and future drift (pick either the tests/tui/* convention or the root tests/tui-*.test.mjs convention used elsewhere).

Suggested change

describe("tui settings screen", () => {

describe.skip("tui settings screen (moved to tests/tui/settings-screen.test.mjs)", () => {

Copilot · 2026-03-25T18:49:37Z

infra/monitor.mjs

+const stopTuiConfigReloadListener = onConfigReload((payload = {}) => {`r`n  runDetached("config-reload:tui", () => reloadConfig(payload.reason || "tui-settings"));`r`n});`r`n`r`nprocess.on("SIGINT", async () => {
  shuttingDown = true;
  stopWorkspaceSyncTimers();


This onConfigReload listener block is currently injected inline with literal rnsequences and is concatenated with the followingprocess.on("SIGINT")handler, which will break parsing. Rewrite this section as properly separated statements (listener registration, thenprocess.on`), and ensure the listener cleanup is syntactically correct and runs during shutdown.

Copilot · 2026-03-25T18:49:37Z

ui/tui/App.js

-      <//>
-    `;
+    body = html`<${ScreenFrame} title="Logs" subtitle="Recent monitor and transport events.">
+      ${wsState.logs.length ? wsState.logs.slice(0, 12).map((entry, index) => html`<${Text} key=${index}>${entry}<//>`) : html`<${Text} color=${ANSI_COLORS.muted}>No log entries yet.<//>`}


wsState.logs entries are logs:stream payload objects (with fields like timestamp/level/line/raw). Rendering ${entry} will display [object Object] and loses the useful formatting previously implemented. Render a formatted string (e.g., timestamp + level + line/raw) or extract entry.line/entry.raw instead.

Suggested change

${wsState.logs.length ? wsState.logs.slice(0, 12).map((entry, index) => html`<${Text} key=${index}>${entry}<//>`) : html`<${Text} color=${ANSI_COLORS.muted}>No log entries yet.<//>`}

${wsState.logs.length

? wsState.logs.slice(0, 12).map((entry, index) => {

const timestamp = entry?.timestamp ? String(entry.timestamp) : "";

const level = entry?.level ? String(entry.level).toUpperCase() : "";

const message = entry?.line ?? entry?.raw ?? JSON.stringify(entry);

const parts = [];

if (timestamp) parts.push(timestamp);

if (level) parts.push(`[${level}]`);

if (message) parts.push(message);

const formatted = parts.join(" ");

return html`<${Text} key=${index}>${formatted}<//>`;

})

: html`<${Text} color=${ANSI_COLORS.muted}>No log entries yet.<//>`}

Copilot · 2026-03-25T18:49:38Z

ui/tui/SettingsScreen.js

+const ENV_PATHS = Object.freeze({
+  "kanban.backend": "KANBAN_BACKEND",
+  telegramUiPort: "TELEGRAM_UI_PORT",
+    "githubProjectSync.webhookSecret": "GITHUB_WEBHOOK_SECRET",
+  "linear.apiKey": "LINEAR_API_KEY",
+  "costRates.inputPer1M": "COST_RATES_INPUT_PER_1M",
+  "costRates.outputPer1M": "COST_RATES_OUTPUT_PER_1M",
+});


ENV_PATHS keys here don’t match the actual config/schema paths (e.g., githubProjectSync.webhookSecret isn’t a config key; the config loader reads kanban.github.project.webhook.secret, and the env var is GITHUB_PROJECT_WEBHOOK_SECRET/GITHUB_WEBHOOK_SECRET). As written, many fields will never show from env/read-only status. Align these mappings with the real config shape in config/config.mjs.

github-actions · 2026-03-25T23:20:35Z

Bosun PR classification: Bosun-created.
This PR is tracked by Bosun attachment automation.

PR class label: bosun-pr-bosun-created
Attach label: bosun-attached (yes, because Bosun-created PRs remain attached regardless of human PR attach mode)
Attach mode policy: all
Trusted author: no
Bosun-created label present: yes
Automation scope: Eligible for Bosun repair and merge automation (Bosun-created PR).
CI failure signal label: bosun-needs-fix
CI failure marker:
Trigger: pull_request_target / synchronize

…ead-edit-bosun-config-

Co-authored-by: bosun-ve[bot] <262908237+bosun-ve[bot]@users.noreply.github.com>

jaeko44 added the bosun-attached Bosun PR attachment marker label Mar 25, 2026

Copilot AI review requested due to automatic review settings March 25, 2026 18:42

Copilot started reviewing on behalf of jaeko44 March 25, 2026 18:42 View session

github-actions bot added the bosun-needs-fix Attached PR with failing CI that Bosun should pick up for repair label Mar 25, 2026

Copilot AI reviewed Mar 25, 2026

View reviewed changes

jaeko44 added 2 commits March 26, 2026 10:20

chore: auto-commit agent work (3ad65810-169)

b1c82b2

chore: auto-commit agent work (3ad65810-169)

df1b666

jaeko44 force-pushed the task/3ad658101698-feat-tui-settings-screen-read-edit-bosun-config- branch from eadff8e to df1b666 Compare March 25, 2026 23:20

github-actions bot added the bosun-pr-public PR observed by Bosun but not trusted for high-risk automation label Mar 25, 2026

jaeko44 added bosun-pr-bosun-created PR created by Bosun and eligible for Bosun automation and removed bosun-pr-public PR observed by Bosun but not trusted for high-risk automation labels Mar 26, 2026

jaeko44 and others added 4 commits March 26, 2026 22:46

Merge branch 'main' into task/3ad658101698-feat-tui-settings-screen-r…

ed9f3d2

…ead-edit-bosun-config-

Merge remote-tracking branch 'origin/main' into HEAD

a3bea20

Co-authored-by: bosun-ve[bot] <262908237+bosun-ve[bot]@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into HEAD

ebb79af

Co-authored-by: bosun-ve[bot] <262908237+bosun-ve[bot]@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into HEAD

20e3d81

Co-authored-by: bosun-ve[bot] <262908237+bosun-ve[bot]@users.noreply.github.com>

jaeko44 added bosun-needs-fix Attached PR with failing CI that Bosun should pick up for repair and removed bosun-needs-fix Attached PR with failing CI that Bosun should pick up for repair labels Mar 26, 2026

jaeko44 added bosun-needs-fix Attached PR with failing CI that Bosun should pick up for repair and removed bosun-needs-fix Attached PR with failing CI that Bosun should pick up for repair labels Mar 27, 2026

	import { createAgentEventBus } from "../agent/agent-event-bus.mjs";`r`nimport { onConfigReload } from "../ui/tui/config-events.js";
	import { createAgentEventBus } from "../agent/agent-event-bus.mjs";
	import { onConfigReload } from "../ui/tui/config-events.js";

		process.on("exit", () => {`r`n try { stopTuiConfigReloadListener?.(); } catch { /* best effort */ }
		shuttingDown = true;


		export function emitConfigReload(payload = {}) {
		bus.emit("config-reload", payload);

-export function emitConfigReload(payload = {}) {
-  bus.emit("config-reload", payload);
+/**
+ * Attempt to notify a parent/monitor process about a config reload over IPC.
+ * This uses Node's built-in `process.send` when an IPC channel is available
+ * (e.g., when this process was spawned with the `ipc` stdio option).
+ */
+function sendConfigReloadIPC(payload) {
+  if (typeof process !== "undefined" && typeof process.send === "function") {
+    try {
+      process.send({ type: "config-reload", payload });
+    } catch {
+      // Swallow IPC errors to avoid breaking local event emission.
+    }
+  }
+}
+export function emitConfigReload(payload = {}) {
+  // Notify listeners within this process.
+  bus.emit("config-reload", payload);
+  // Also attempt to notify any parent/monitor process over IPC.
+  sendConfigReloadIPC(payload);

	describe("tui settings screen", () => {
	describe.skip("tui settings screen (moved to tests/tui/settings-screen.test.mjs)", () => {

-      ${wsState.logs.length ? wsState.logs.slice(0, 12).map((entry, index) => html`<${Text} key=${index}>${entry}<//>`) : html`<${Text} color=${ANSI_COLORS.muted}>No log entries yet.<//>`}
+      ${wsState.logs.length
+        ? wsState.logs.slice(0, 12).map((entry, index) => {
+            const timestamp = entry?.timestamp ? String(entry.timestamp) : "";
+            const level = entry?.level ? String(entry.level).toUpperCase() : "";
+            const message = entry?.line ?? entry?.raw ?? JSON.stringify(entry);
+            const parts = [];
+            if (timestamp) parts.push(timestamp);
+            if (level) parts.push(`[${level}]`);
+            if (message) parts.push(message);
+            const formatted = parts.join(" ");
+            return html`<${Text} key=${index}>${formatted}<//>`;
+          })
+        : html`<${Text} color=${ANSI_COLORS.muted}>No log entries yet.<//>`}

Conversation

jaeko44 commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading