feat(tui): Settings screen read/edit bosun.config.json fields inline with validation

infra/monitor.mjs

@@ -224,7 +224,7 @@ import {
   getAllTasks as getAllInternalTasks,
 } from "../task/task-store.mjs";
 import { createAgentEndpoint } from "../agent/agent-endpoint.mjs";
-import { createAgentEventBus } from "../agent/agent-event-bus.mjs";
+import { createAgentEventBus } from "../agent/agent-event-bus.mjs";`r`nimport { onConfigReload } from "../ui/tui/config-events.js";
 import { createReviewAgent } from "../agent/review-agent.mjs";
 
 import { createErrorDetector } from "./error-detector.mjs";
@@ -13286,6 +13286,10 @@ async function reloadConfig(reason) {
   }
 }
 
+const stopTuiConfigReloadListener = onConfigReload((payload = {}) => {
+  runDetached("config-reload:tui", () => reloadConfig(payload.reason || "tui-settings"));
+});
+
 process.on("SIGINT", async () => {
   shuttingDown = true;
   stopWorkspaceSyncTimers();
@@ -13333,7 +13337,7 @@ process.on("SIGINT", async () => {
 });
 
 // Windows: closing the terminal window doesn't send SIGINT/SIGTERM reliably.
-process.on("exit", () => {
+process.on("exit", () => {`r`n  try { stopTuiConfigReloadListener?.(); } catch { /* best effort */ }
   shuttingDown = true;
   stopWorkspaceSyncTimers();
   stopAgentAlertTailer();
@@ -15037,3 +15041,5 @@ export {
 };
 
 
+
+

tests/tui-settings-screen.test.mjs

@@ -0,0 +1,121 @@
+import { mkdtempSync, readFileSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+import React from "react";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+import SettingsScreen from "../ui/tui/SettingsScreen.js";
+import { renderInk } from "./tui/render-ink.mjs";
+import { waitFor } from "./tui/render-helpers.mjs";
+
+function createConfigDir(config) {
+  const dir = mkdtempSync(join(tmpdir(), "bosun-settings-"));
+  const path = join(dir, "bosun.config.json");
+  writeFileSync(path, JSON.stringify(config, null, 2));
+  return { dir, path };
+}
+
+function readJson(path) {
+  return JSON.parse(readFileSync(path, "utf8"));
+}
+
+describe("tui settings screen", () => {
+  const originalEnv = process.env;
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.KANBAN_BACKEND;
+    delete process.env.TELEGRAM_UI_PORT;
+    delete process.env.TELEGRAM_BOT_TOKEN;
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+    vi.restoreAllMocks();
+  });
+
+  it("renders grouped config fields with masked secrets and source labels", async () => {
+    process.env.TELEGRAM_BOT_TOKEN = "env-token";
+
+    const { dir } = createConfigDir({
+      kanban: { backend: "github" },
+      telegram: { uiPort: 3080, token: "config-token" },
+      costRates: { inputPer1M: 1.5 },
+    });
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, {
+        configDir: dir,
+        config: { kanban: { backend: "github" }, telegram: { uiPort: 3080, token: "config-token" }, costRates: { inputPer1M: 1.5 } },
+      }),
+      { columns: 220, rows: 60 },
+    );
+
+    const text = view.text();
+    expect(text).toContain("General");
+    expect(text).toContain("Kanban");
+    expect(text).toContain("Integrations");
+    expect(text).toContain("Cost Rates");
+    expect(text).toContain("backend");
+    expect(text).toContain("github");
+    expect(text).toContain("from config");
+    expect(text).toContain("from env");
+    expect(text).toContain("****");
+    expect(text).not.toContain("env-token");
+
+    await view.unmount();
+  });
+
+  it("saves an edited enum field atomically and emits config reload", async () => {
+    const { dir, path } = createConfigDir({
+      kanban: { backend: "internal" },
+    });
+    const emitReload = vi.fn();
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, {
+        configDir: dir,
+        config: { kanban: { backend: "internal" } },
+        onConfigReload: emitReload,
+      }),
+      { columns: 220, rows: 60 },
+    );
+
+    await waitFor(() => view.text().includes("backend: internal"));
+    await view.press("\r");
+    await view.press("\u001b[C", 80);
+
+    await waitFor(() => readJson(path).kanban.backend === "github");
+    expect(readJson(path).kanban.backend).toBe("github");
+    expect(emitReload).toHaveBeenCalledTimes(1);
+    expect(emitReload).toHaveBeenCalledWith(expect.objectContaining({ configPath: path }));
+
+    await view.unmount();
+  });
+
+  it("blocks invalid numeric edits and keeps the file unchanged", async () => {
+    const { dir, path } = createConfigDir({
+      telegram: { uiPort: 3080 },
+    });
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, {
+        configDir: dir,
+        config: { telegram: { uiPort: 3080 } },
+      }),
+      { columns: 220, rows: 60 },
+    );
+
+    await waitFor(() => view.text().includes("uiPort: 3080"));
+    await view.press("j", 40);
+    await view.press("\r");
+    await view.press("999999999999", 40);
+    await view.press("\u0013", 80);
+
+    await waitFor(() => view.text().includes("Validation error"));
+    expect(readJson(path).telegram.uiPort).toBe(3080);
+
+    await view.unmount();
+  });
+});

tests/tui/settings-screen.test.mjs

@@ -0,0 +1,107 @@
+import { mkdtempSync, readFileSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import React from "react";
+import { beforeEach, afterEach, describe, expect, it, vi } from "vitest";
+
+import SettingsScreen from "../../ui/tui/SettingsScreen.js";
+import { renderInk } from "./render-ink.mjs";
+
+function makeConfigDir(config) {
+  const dir = mkdtempSync(join(tmpdir(), "bosun-settings-"));
+  writeFileSync(join(dir, "bosun.config.json"), `${JSON.stringify(config, null, 2)}\n`, "utf8");
+  return dir;
+}
+
+describe("tui settings screen", () => {
+  const originalEnv = process.env;
+
+  beforeEach(() => {
+    process.env = { ...originalEnv };
+    delete process.env.TELEGRAM_BOT_TOKEN;
+    delete process.env.KANBAN_BACKEND;
+    delete process.env.LINEAR_API_KEY;
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+    vi.restoreAllMocks();
+  });
+
+  it("renders grouped schema fields and masks secrets by default", async () => {
+    process.env.TELEGRAM_BOT_TOKEN = "env-secret-token";
+
+    const configDir = makeConfigDir({
+      projectName: "demo",
+      kanban: { backend: "github" },
+      linear: { apiKey: "super-secret" },
+      telegramBotToken: "local-secret",
+      costRates: { inputPer1M: 1, outputPer1M: 2 },
+    });
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, { configDir, config: {} }),
+      { columns: 220, waitMs: 120 },
+    );
+
+    const text = view.text();
+    expect(text).toContain("General");
+    expect(text).toContain("Kanban");
+    expect(text).toContain("Integrations");
+    expect(text).toContain("Cost Rates");
+    expect(text).toContain("linear.apiKey");
+    expect(text).toContain("telegramBotToken");
+    expect(text).toContain("from env");
+    expect(text).toContain("****");
+    expect(text).not.toContain("env-secret-token");
+
+    await view.unmount();
+  });
+
+  it("writes enum changes to bosun.config.json and emits reload", async () => {
+    const configDir = makeConfigDir({ kanban: { backend: "github" } });
+    const emitReload = vi.fn();
+
+    const view = await renderInk(
+      React.createElement(SettingsScreen, { configDir, config: {}, onConfigReload: emitReload }),
+      { columns: 220, waitMs: 120 },
+    );
+
+    for (let index = 0; index < 120 && !view.text().includes("> kanban.backend"); index += 1) {
+      await view.press("j", 5);
+    }
+    await view.press("\u001b[C", 120);
+
+    const updated = JSON.parse(readFileSync(join(configDir, "bosun.config.json"), "utf8"));
+    expect(updated.kanban.backend).not.toBe("github");
+    expect(emitReload).toHaveBeenCalledTimes(1);
+    expect(emitReload).toHaveBeenCalledWith(expect.objectContaining({
+      configPath: join(configDir, "bosun.config.json"),
+      reason: "settings-save",
+    }));
+
+    await view.unmount();
+  });
+
+  it("prevents invalid numeric saves and leaves file unchanged", async () => {
+    const configDir = makeConfigDir({ cloudflareDnsMaxRetries: 3 });
+    const before = readFileSync(join(configDir, "bosun.config.json"), "utf8");
+    const view = await renderInk(
+      React.createElement(SettingsScreen, { configDir, config: {} }),
+      { columns: 220, waitMs: 120 },
+    );
+
+    for (let index = 0; index < 220 && !view.text().includes("> cloudflareDnsMaxRetries"); index += 1) {
+      await view.press("j", 5);
+    }
+    await view.press("\r", 60);
+    await view.press("abc", 20);
+    await view.press("\u0013", 120);
+
+    expect(view.text()).toContain("Validation error");
+    const after = readFileSync(join(configDir, "bosun.config.json"), "utf8");
+    expect(after).toBe(before);
+
+    await view.unmount();
+  });
+});