chore: add playwright-ct tests #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikg
reviewed
Jun 14, 2024
| '@sveltejs/vite-plugin-svelte-inspector': true, | ||
| }, | ||
| build: 'build', | ||
| beforeTest: 'npx playwright install --with-deps', |
There was a problem hiding this comment.
do we need all here or can we limit it to chromium?
dominikg
reviewed
Jun 14, 2024
| overrides: { | ||
| '@vitejs/plugin-react': true, | ||
| '@vitejs/plugin-vue': true, | ||
| '@vitejs/plugin-vue2': true, |
There was a problem hiding this comment.
we don't have a build config for that currently, it would have to be added to builds, similar to https://github.com/vitejs/vite-ecosystem-ci/blob/main/builds/vite-plugin-vue.ts
Is this something that adds more coverage over just plugin-vue, if not i'd prefer to not have this override and use a reduced ct-vite-ecosystem-ci test script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that would help the ecosystem in order to prevent e.g. vitejs/vite#17478