Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add playwright-ct tests #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

chore: add playwright-ct tests #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ecosystem-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
- nuxt
# - nx # disabled temporarily
- previewjs
- playwright-ct
- quasar
- qwik
- rakkas
Expand Down
20 changes: 20 additions & 0 deletions tests/playwright-ct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { runInRepo } from '../utils.ts'
import type { RunOptions } from '../types.d.ts'

export async function test(options: RunOptions) {
await runInRepo({
...options,
repo: 'microsoft/playwright',
overrides: {
'@vitejs/plugin-react': true,
'@vitejs/plugin-vue': true,
'@vitejs/plugin-vue2': true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have a build config for that currently, it would have to be added to builds, similar to https://github.com/vitejs/vite-ecosystem-ci/blob/main/builds/vite-plugin-vue.ts

Is this something that adds more coverage over just plugin-vue, if not i'd prefer to not have this override and use a reduced ct-vite-ecosystem-ci test script.

svelte: 'latest',
'@sveltejs/vite-plugin-svelte': true,
'@sveltejs/vite-plugin-svelte-inspector': true,
},
build: 'build',
beforeTest: 'npx playwright install --with-deps',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need all here or can we limit it to chromium?

test: ['ct'],
})
}
Loading