Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): SpatialData wrapper #333

Closed
wants to merge 63 commits into from
Closed

Conversation

ilan-gold
Copy link
Collaborator

@ilan-gold ilan-gold commented Apr 11, 2024

This is a first pass at a SpatialData wrapper.

Complete #331 for SpatialData via a static method (my preferred solution for 331).

Some todos:

@ilan-gold ilan-gold changed the base branch from main to ig/anndata_api_cleanup May 7, 2024 09:29
@ilan-gold
Copy link
Collaborator Author

@keller-mark Fixing notebook, apologies

@ilan-gold
Copy link
Collaborator Author

@keller-mark The only thing happening here is the obsSets is not appearing in the component. Also, selections only kind of working, generating a set, but not actually rendering the result on the image spots.....if you can't see anything immediately going on I'd be happy to investigate as a bug. Thanks!

keller-mark and others added 3 commits October 2, 2024 08:43
* Added utility functions to update and remove a view

* Added tests for the utility functions

* Refactored to multiple functions
* Update exports for createPlugins

* Version
@ilan-gold ilan-gold requested a review from keller-mark October 4, 2024 14:53
ilan-gold and others added 4 commits October 4, 2024 17:18
…stores (#371)

* Register artifacts in wrapper constructors

* Docs

* Add test

* Update

* Version bump

* Lint

* Update is_remote logic

* Update
* Try again

* Fix bugs

* Lint

* Update

* Omit
@keller-mark keller-mark mentioned this pull request Oct 7, 2024
keller-mark and others added 5 commits October 7, 2024 16:19
* Try again

* Fix bugs

* Lint

* Update

* Omit

* Add test

* JS version
* (refactor): separate out schema creation

* (feat): initial pass at spatial data

* (feat): working notebook minus spots (maybe a vitessce bug?)

* (fix): try to get spots to appear

* (chore): comment out other stuff to make widget show more

* Fix visium config

* (feat): firstt pass at `from_spatialdata_object`

* (refactor): refactor `from_spatialdata_object` and util funcs from static methods

* (feat): add url capability

* (temp): spatial data fixes

* (chore): change variable names

* (chore): fix notebooks

* (refactor): `path`->`elem`

* (chore): more clean ups and fixes

* (refactor): small name changes

* (refactor): revert public changes

* (fix): revert `.ipynb` files

* (chore): fix last final args

* (fix): name

* (fix): remove `request_init` completely and fix `setup.cfg`

* (fix): adapt to api

* (chore): remove erroneous notebook

* (fix): add type support

* (chore): add test

* (fix): automatic lint

* (fix): add default for `obsEmbedding`

* (fix): redefinition

* (fix): `path` and `embeddingType` swapped

* (fix): add annotattions to `utils.py`

* (chore): add `spatialdata` dep

* (fix): oops, comma for `toml`

* (fix): no more python3.8 bc of spatialdata

* (fix): remove whitespace

* (api): small api cleanups

* (fix): args bug

* (fix): try spatialdata from master

* (chore): lint

* (chore): try `spatialdata` update

* (fix): `image_elem` usage + table key

* (chore): update SpatialData

* (fix): `shapes_elem`

* (fix): capitalize name of obs set

* (fix): use table for spots

* (fix): capitalization

* (fix): first letter only

* (fix): check `self._coordination_values`

* (chore): add `obsSets` check

* SpatialData changes into original SpatialData branch (#374)

* Try again

* Fix bugs

* Lint

* Update

* Omit

* Update pyproject.toml

* Keller mark/spatial data2 (#375)

* Try again

* Fix bugs

* Lint

* Update

* Omit

* Add test

* JS version

---------

Co-authored-by: ilan-gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants