-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: Add changelog entry for QueryThrottler observability metrics #19036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
|
🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them. |
|
Promptless escalated the following message to you. If you respond, please remember to tag Promptless: The CI check failed because the PR is missing required labels. All PRs in the vitessio/vitess repository must have:
For this changelog documentation PR, you'll need to add:
You can add these labels through the GitHub UI by clicking the gear icon next to "Labels" in the right sidebar of the PR page. Once the labels are added, the CI check should pass automatically. |
…uerythrottler-metrics Signed-off-by: Matt Lord <[email protected]>
5d65d85 to
a538441
Compare
|
Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.) |
…itessio#19036) Signed-off-by: Matt Lord <[email protected]> Co-authored-by: promptless[bot] <179508745+promptless[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]>
Documents PR #18740, which adds four new observability metrics to VTTablet's QueryThrottler. The metrics track total requests evaluated, throttled requests, total latency, and evaluation latency. Each metric includes labels for Strategy, Workload, and Priority, with the throttled metric providing additional context about which metric triggered throttling and whether it was in dry-run mode.
Trigger Events
Open this suggestion in the Promptless dashboard
Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.
If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)