-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient
#19085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix bug where `ReloadSchema` was incorrectly set to `req.DisableBinlogs` instead of `req.ReloadSchema` in `ExecuteFetchAsDba` and `ExecuteMultiFetchAsDba` Signed-off-by: Mohamed Hamza <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
ReloadSchema incorrectly using DisableBinlogs value in grpctmclient
ReloadSchema incorrectly using DisableBinlogs value in grpctmclientReloadSchema incorrectly using DisableBinlogs value in grpctmclient
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19085 +/- ##
==========================================
+ Coverage 69.88% 69.89% +0.01%
==========================================
Files 1612 1613 +1
Lines 215822 216023 +201
==========================================
+ Hits 150828 150996 +168
- Misses 64994 65027 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Pull request was converted to draft
81a69e6 to
0cd9f4e
Compare
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
ReloadSchema incorrectly using DisableBinlogs value in grpctmclientReloadSchema incorrectly using DisableBinlogs value in grpctmclient and fixes resulting bug
Signed-off-by: Mohamed Hamza <[email protected]>
ReloadSchema incorrectly using DisableBinlogs value in grpctmclient and fixes resulting bugReloadSchema incorrectly using DisableBinlogs value in grpctmclient
Description
Fixes a small bug where
ReloadSchemawas incorrectly set toreq.DisableBinlogsinstead ofreq.ReloadSchemainExecuteFetchAsDbaandExecuteMultiFetchAsDba.Some backup test cases broke as a result of this fix, since they silently relied on the fact
ExecuteFetchAsDbawasn't properly reloading the schema cache. Fixed by resetting test state in between runs.Related Issue(s)
Checklist
Deployment Notes
AI Disclosure