Skip to content

Conversation

@mhamza15
Copy link
Collaborator

@mhamza15 mhamza15 commented Dec 25, 2025

Description

Fixes a small bug where ReloadSchema was incorrectly set to req.DisableBinlogs instead of req.ReloadSchema in ExecuteFetchAsDba and ExecuteMultiFetchAsDba.

Some backup test cases broke as a result of this fix, since they silently relied on the fact ExecuteFetchAsDba wasn't properly reloading the schema cache. Fixed by resetting test state in between runs.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Fix bug where `ReloadSchema` was incorrectly set to `req.DisableBinlogs` instead of `req.ReloadSchema` in `ExecuteFetchAsDba` and `ExecuteMultiFetchAsDba`

Signed-off-by: Mohamed Hamza <[email protected]>
@mhamza15 mhamza15 self-assigned this Dec 25, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 25, 2025
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 25, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 25, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mhamza15 mhamza15 changed the title Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Dec 25, 2025
@mhamza15 mhamza15 changed the title Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Dec 25, 2025
@mhamza15 mhamza15 added Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 25, 2025
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (ffa1e9b) to head (8e237fb).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/grpctmclient/client.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19085      +/-   ##
==========================================
+ Coverage   69.88%   69.89%   +0.01%     
==========================================
  Files        1612     1613       +1     
  Lines      215822   216023     +201     
==========================================
+ Hits       150828   150996     +168     
- Misses      64994    65027      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhamza15 mhamza15 enabled auto-merge (squash) January 7, 2026 23:40
@mhamza15 mhamza15 marked this pull request as draft January 9, 2026 13:57
auto-merge was automatically disabled January 9, 2026 13:57

Pull request was converted to draft

@mhamza15 mhamza15 changed the title Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient and fixes resulting bug Jan 10, 2026
@mhamza15 mhamza15 marked this pull request as ready for review January 10, 2026 01:24
@mhamza15 mhamza15 requested a review from frouioui as a code owner January 10, 2026 01:24
@mhamza15 mhamza15 requested review from arthurschreiber and nickvanw and removed request for frouioui, rohit-nayak-ps and shlomi-noach January 10, 2026 01:24
@mhamza15 mhamza15 changed the title Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient and fixes resulting bug Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient Jan 10, 2026
@mhamza15 mhamza15 merged commit b46ca54 into vitessio:main Jan 12, 2026
103 checks passed
@mhamza15 mhamza15 deleted the reload-schema-req branch January 12, 2026 14:23
mattlord pushed a commit that referenced this pull request Jan 12, 2026
mattlord pushed a commit that referenced this pull request Jan 12, 2026
vitess-bot bot added a commit that referenced this pull request Jan 12, 2026
mhamza15 pushed a commit that referenced this pull request Jan 12, 2026
…value in `grpctmclient` (#19085) (#19129)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
mhamza15 pushed a commit that referenced this pull request Jan 12, 2026
…value in `grpctmclient` (#19085) (#19130)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 Component: TabletManager Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants