Skip to content

Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient #19085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhamza15 merged 6 commits into from
Jan 12, 2026
+5 −5
Merged

Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient #19085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63df8e9
Fix ReloadSchema incorrectly using DisableBinlogs value in grpctmclient
mhamza15 Dec 25, 2025
372d387
Merge branch 'main' into reload-schema-req
mhamza15 Jan 6, 2026
0cd9f4e
Merge remote-tracking branch 'upstream/main' into reload-schema-req
mhamza15 Jan 7, 2026
97e0168
add reproduction test case
mhamza15 Jan 10, 2026
77518ec
reload schema before taking backup
mhamza15 Jan 10, 2026
8e237fb
remove fix and properly reset state between tests
mhamza15 Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/test/endtoend/backup/vtctlbackup/backup_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func LaunchCluster(setupType int, streamMode string, stripes int, cDetails *Comp
return 1, err
}
newInitDBFile = path.Join(localCluster.TmpDirectory, "init_db_with_passwords.sql")
err = os.WriteFile(newInitDBFile, []byte(sql), 0666)
err = os.WriteFile(newInitDBFile, []byte(sql), 0o666)
if err != nil {
return 1, err
}
Expand Down Expand Up @@ -561,10 +561,10 @@ func primaryBackup(t *testing.T) {

_, err = primary.VttabletProcess.QueryTablet("DROP TABLE vt_insert_test", keyspaceName, true)
require.NoError(t, err)

restartPrimaryAndReplica(t)
}

// Test a primary and replica from the same backup.
//
// Check that a replica and primary both restored from the same backup
// can replicate successfully.
func primaryReplicaSameBackup(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions go/vt/vttablet/grpctmclient/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ func (client *Client) ExecuteFetchAsDba(ctx context.Context, tablet *topodatapb.
DbName: topoproto.TabletDbName(tablet),
MaxRows: req.MaxRows,
DisableBinlogs: req.DisableBinlogs,
ReloadSchema: req.DisableBinlogs,
ReloadSchema: req.ReloadSchema,
DisableForeignKeyChecks: req.DisableForeignKeyChecks,
})
if err != nil {
Expand Down Expand Up @@ -707,7 +707,7 @@ func (client *Client) ExecuteMultiFetchAsDba(ctx context.Context, tablet *topoda
DbName: topoproto.TabletDbName(tablet),
MaxRows: req.MaxRows,
DisableBinlogs: req.DisableBinlogs,
ReloadSchema: req.DisableBinlogs,
ReloadSchema: req.ReloadSchema,
DisableForeignKeyChecks: req.DisableForeignKeyChecks,
})
if err != nil {
Expand Down
Loading