Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Dec 17, 2025

Added comprehensive documentation for the new Query Throttler feature introduced in PR #18449. The Query Throttler protects tablets from being overloaded by incoming user queries, unlike the existing Tablet Throttler which manages outgoing operations like VReplication and Online DDL.

Preview: https://deploy-preview-2046--vitess.netlify.app/docs/24.0/reference/features/query-throttler/

Key documentation includes:

  • Pluggable architecture with NoOp and TabletThrottler strategies
  • Priority-based throttling using PRIORITY comment directive (0-100 scale)
  • Workload classification support via WORKLOAD_NAME directive
  • Configuration via JSON file with graduated thresholds
  • Support for multiple metrics (lag, threads_running, loadavg, etc.)
  • Performance characteristics (<5% overhead in healthy systems)
  • Best practices and monitoring guidance

The documentation references RFC #18412 for architecture design and configuration patterns.

Trigger Events

Open this suggestion in the Promptless dashboard


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@mattlord mattlord self-requested a review December 17, 2025 20:32
@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 256e72a
🔍 Latest deploy log https://app.netlify.com/projects/vitess/deploys/69440d551afa730008aa347a
😎 Deploy Preview https://deploy-preview-2046--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Matt Lord <[email protected]>
@promptless
Copy link
Contributor Author

promptless bot commented Dec 18, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

Copy link
Collaborator

@siddharth16396 siddharth16396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Configuration

The throttler loads configuration from a JSON file at `/config/throttler-config.json` by default. Configuration is refreshed periodically (default: every 1 minute) without requiring tablet restarts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go away with vitessio/vitess#18979
I guess we'll run promptless again post that PR is merged :D

@mattlord mattlord merged commit 2a004ad into prod Dec 18, 2025
5 checks passed
@mattlord mattlord deleted the promptless/document-query-throttler branch December 18, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants