Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C# customer-profile rest service #188

Closed
wants to merge 12 commits into from
Closed

Add C# customer-profile rest service #188

wants to merge 12 commits into from

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Feb 13, 2023 •
edited
Loading

Adds a C# variant of java-rest-service that is compatible with the angular-frontend accelerator.

Also updates the tiltfile in weatherforecast-steeltoe to resolve #149

@TimHess TimHess mentioned this pull request Feb 13, 2023
Closed
ccheetham
ccheetham reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ccheetham ccheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the suggested edits, the instructions for running commands end with "by running." However that's just a suggestion; gist is to use a descriptive manner for running commands.

csharp-rest-service/Controllers/CustomerProfilesController.cs Outdated Show resolved Hide resolved
csharp-rest-service/README.md Outdated Show resolved Hide resolved
csharp-rest-service/README.md Outdated Show resolved Hide resolved
csharp-rest-service/README.md Outdated Show resolved Hide resolved
csharp-rest-service/README.md Outdated Show resolved Hide resolved
@TimHess TimHess requested a review from ccheetham February 15, 2023 22:48
@trisberg
Copy link
Member

Squashed and rebased - merged via 10cb9f9

@trisberg trisberg closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisberg trisberg trisberg left review comments

@ccheetham ccheetham Awaiting requested review from ccheetham

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tiltfile OUTPUT_TO_NULL_COMMAND not recognized on Windows
4 participants
@TimHess @trisberg @ccheetham @vmwclabot