[patch] Add support for endpoint for listing customer's redeemables #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface as it is not available
…abel List since it is not the same as Voucher type
… not Record. Add more fields to 'RedeemableContainerVoucher'
…tomerRedeemablesListResponse'
Closed
marcin-slezak
requested changes
Apr 19, 2024
| camapign_id?: string | ||
| category_id?: string | ||
| type: 'GIFT_VOUCHER' | 'DISCOUNT_VOUCHER' | 'LOYALTY_CARD' | ||
| discount?: DiscountAmount | DiscountPercent | DiscountUnit | DiscountFixed |
There was a problem hiding this comment.
It looks like we do not cover "Unit Multiple" discount type in SDK. To make it a little more complex, in docs, we have two different types, "Unit" and "Unit Multiple" which have exclusively "units" attribute:
In the Voucherify domain, there is one DTO for both cases that has the "units" key. In SDK, I don't see the "units" key in the "DiscountUnit" type nor "DiscountUnitMultiple" defined.
marcin-slezak
requested changes
Apr 19, 2024
added 2 commits
April 19, 2024 16:42
- types names following CONTRIBUTING.md - add missing voucher.gift.effect - adding missing voucher.loyalty_card.next_expiration_date and voucher.loyalty_card.next_expiration_points - adding missing voucher.redemption.redeemed_points - voucher.active as optional field
marcin-slezak
approved these changes
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type
Patch
Changes:
customers/{id}/redeemablesendpoint - https://docs.voucherify.io/reference/list-customer-redeemables