Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Add support for endpoint for listing customer's redeemables #268
[patch] Add support for endpoint for listing customer's redeemables #268
Changes from all commits
3234798
1ec21c6
6804d0a
b1951c2
c7aaa6b
e28df11
e28c9d8
38800fd
9dd0311
73df162
cc98947
e870816
f87f608
3b992e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we do not cover "Unit Multiple" discount type in SDK. To make it a little more complex, in docs, we have two different types, "Unit" and "Unit Multiple" which have exclusively "units" attribute:
In the Voucherify domain, there is one DTO for both cases that has the "units" key. In SDK, I don't see the "units" key in the "DiscountUnit" type nor "DiscountUnitMultiple" defined.