fix: Multiple deps issue with our tachyons-css & radix deps #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artmsilva
changed the title
artmsilva
changed the title
val-l-hosler
approved these changes
Jun 17, 2024
artmsilva
commented
Jun 20, 2024
| "@radix-ui/react-focus-scope": "^1.0.0", | ||
| "@radix-ui/react-label": "^1.0.0", | ||
| "@radix-ui/react-navigation-menu": "^1.0.0", | ||
| "@radix-ui/react-popover": "^1.0.2", | ||
| "@radix-ui/react-primitive": "^1.0.2", | ||
| "@radix-ui/react-radio-group": "^1.0.0", | ||
| "@radix-ui/react-select": "^1.2.2", | ||
| "@radix-ui/react-select": "^2.0.0", |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I had to roll out a feat & patch release to tachyons-css to update how we add kit as a dep to the stylesheet. washingtonpost/tachyons-css@26bb36b. I also upgraded some our radix deps in order for them all to use the same version (Menu, popper, popover)
Testing Steps