Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Multiple deps issue with our tachyons-css & radix deps #644

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Multiple deps issue with our tachyons-css & radix deps #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
052a9a1
fix: deps issue with tachyons & radix deps
artmsilva Jun 17, 2024
bc6e0e0
chore: commit save point
artmsilva Jun 17, 2024
7ebe8e9
chore: fix e2e tests
artmsilva Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions build.washingtonpost.com/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
"@docsearch/react": "^3.0.0",
"@mdx-js/react": "^3.0.1",
"@octokit/core": "^4.0.5",
"@radix-ui/react-accordion": "^1.0.0",
"@radix-ui/react-checkbox": "^1.0.0",
"@radix-ui/react-collapsible": "^1.0.0",
"@radix-ui/react-toggle-group": "^1.0.1",
"@stitches/react": "1.2.8",
"@washingtonpost/front-end-utils": "0.5.17-alpha.1",
"@washingtonpost/site-favicons": "0.3.4-alpha.1",
"@washingtonpost/site-footer": "0.25.3-alpha.1",
"@washingtonpost/tachyons-css": "^1.8.0",
"@radix-ui/react-accordion": "latest",
"@radix-ui/react-checkbox": "latest",
"@radix-ui/react-collapsible": "latest",
"@radix-ui/react-toggle-group": "latest",
"@stitches/react": "^1.2.8",
"@washingtonpost/front-end-utils": "latest",
"@washingtonpost/site-favicons": "latest",
"@washingtonpost/site-footer": "latest",
"@washingtonpost/tachyons-css": "^1.10.1",
"@washingtonpost/wpds-assets": "2.0.0",
"@washingtonpost/wpds-kitchen-sink": "2.3.1",
"@washingtonpost/wpds-tailwind-theme": "2.3.1",
Expand Down
45 changes: 18 additions & 27 deletions e2e/form-example.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test.describe("errors should show", () => {
test("does not pass @ or .com", async ({ page }) => {
await page.goto(workingExamplePage);

await page.locator("input[aria-labelledby='radix-2']").fill("j");
await page.locator("input[name='email']").fill("j");

await page.locator("[type=submit]").click();

Expand All @@ -36,9 +36,7 @@ test.describe("errors should show", () => {
test("does not pass .com", async ({ page }) => {
await page.goto(workingExamplePage);

await page
.locator("input[aria-labelledby='radix-2']")
.fill("john.doe@washpost");
await page.locator("input[name='email']").fill("john.doe@washpost");

await page.locator("[type=submit]").click();

Expand All @@ -49,9 +47,7 @@ test.describe("errors should show", () => {
test("does not pass @", async ({ page }) => {
await page.goto(workingExamplePage);

await page
.locator("input[aria-labelledby='radix-2']")
.fill("john.doewashpost.com");
await page.locator("input[name='email']").fill("john.doewashpost.com");

await page.locator("[type=submit]").click();

Expand All @@ -65,7 +61,7 @@ test.describe("errors should show", () => {
test("has less than 10 digits", async ({ page }) => {
await page.goto(workingExamplePage);

await page.locator("input[aria-labelledby='radix-3']").fill("123456789");
await page.locator("input[name='phone']").fill("123456789");

await page.locator("[type=submit]").click();

Expand All @@ -76,9 +72,7 @@ test.describe("errors should show", () => {
test("has too many digits", async ({ page }) => {
await page.goto(workingExamplePage);

await page
.locator("input[aria-labelledby='radix-3']")
.fill("1234567890112");
await page.locator("input[name='phone']").fill("1234567890112");

await page.locator("[type=submit]").click();

Expand All @@ -89,7 +83,7 @@ test.describe("errors should show", () => {
test("passes in a letter", async ({ page }) => {
await page.goto(workingExamplePage);

await page.locator("input[aria-labelledby='radix-3']").fill("123456789a");
await page.locator("input[name='phone']").fill("123456789a");
await page.locator("[type=submit]").click();
await expect(
page.locator("text=Please pass in a valid phone number")
Expand All @@ -104,22 +98,19 @@ test.describe("no errors should show", () => {
}) => {
await page.goto(workingExamplePage);

await page.locator("input[aria-labelledby='radix-0']").fill("John");
await page.locator("input[aria-labelledby='radix-1']").fill("Doe");
await page
.locator("input[aria-labelledby='radix-2']")
.fill("[email protected]");
await page.locator("input[aria-labelledby='radix-3']").fill("1231231234");
await page.locator("input[aria-labelledby='radix-4']").fill("123 Street");
await page.locator("input[aria-labelledby='radix-6']").fill("New York");
await page.locator("input[aria-labelledby='radix-7']").fill("10001");
await page.locator("input[name='firstName']").fill("John");
await page.locator("input[name='lastName']").fill("Doe");
await page.locator("input[name='email']").fill("[email protected]");
await page.locator("input[name='phone']").fill("1231231234");
await page.locator("input[name='address']").fill("123 Street");
await page.locator("input[name='city']").fill("New York");
await page.locator("input[name='zip']").fill("10001");
await page.locator("select").selectOption("New York");
await page.locator("input[aria-labelledby='radix-9']").fill("Password1!");
await page.locator("input[aria-labelledby='radix-10']").fill("Password1!");
await page
.locator("textarea[aria-labelledby='radix-11']")
.fill("Notes go here");
await page.locator("button[aria-labelledby='radix-13']").click(); // radio buttons
await page.locator("input[name='password']").fill("Password1!");
await page.locator("input[name='password2']").fill("Password1!");
await page.locator("textarea[name='notes']").fill("Notes go here");
// select a radio button
await page.getByLabel("Instagram").check();
await page.locator("[role='checkbox']").check();

await page.locator("[type=submit]").click();
Expand Down
Loading
Loading