Remove special layout code for customizable select #56988
Merged
+154
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we can control the rendering of everything in customizable select in the UA stylesheet with -internal-appearance-base-select(), we don't need code in layout to specially construct the layout tree anymore. This adds some logic to the UA stylesheet and removes everything in LayoutFlexibleBox::IsChildAllowed in the case that the CustomizableSelect flag is disabled. Bug: 364348901, 427778335 Fixed: 452087739 Change-Id: Ia18b10714cf437e971f7dc265565835a3fbf84e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6208372 Reviewed-by: Kent Tamura <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1564394}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6208372
branch
from
7fac2de to
d5ce97a
Compare
wpt-pr-bot
approved these changes
Jan 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can control the rendering of everything in customizable
select in the UA stylesheet with -internal-appearance-base-select(), we
don't need code in layout to specially construct the layout tree
anymore. This adds some logic to the UA stylesheet and removes
everything in LayoutFlexibleBox::IsChildAllowed in the case that the
CustomizableSelect flag is disabled.
Bug: 364348901, 427778335
Fixed: 452087739
Change-Id: Ia18b10714cf437e971f7dc265565835a3fbf84e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6208372
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1564394}