Skip to content

Remove special layout code for customizable select #56988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Jan 5, 2026
Merged

Remove special layout code for customizable select #56988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ics/forms/the-select-element/customizable-select/resources/customizable-select-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
border-radius: 0.5em;
cursor: default;
text-align: inherit;
/* TODO(crbug.com/41483940): Make display match the UA stylesheet. */
display: inline-flex;
gap: 0.5em;
overflow-x: hidden;
Expand Down
4 changes: 4 additions & 0 deletions ...cs/forms/the-select-element/customizable-select/select-appearance-sizing-in-flex-ref.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
select {
appearance: base-select;
}

::picker-icon {
display: none;
}
</style>

<div class="container">
Expand Down
7 changes: 7 additions & 0 deletions ...antics/forms/the-select-element/customizable-select/select-appearance-sizing-in-flex.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
select, .after {
white-space: nowrap;
}

/* ::picker-icon will render inline in this test but on a new line in the
* reference because the select's inner element is display:block and can't be
* changed. */
::picker-icon {
display: none;
}
</style>

<div class="container">
Expand Down
16 changes: 16 additions & 0 deletions html/semantics/forms/the-select-element/customizable-select/select-display-block-ref.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<link rel=stylesheet href="resources/customizable-select-styles.css">

<style>
.customizable-select-button {
display: block;
width: 100px;
}
.customizable-select-button::after {
display: block;
}
</style>

<div class=customizable-select-button popovertarget=popover id=button>
<span class=customizable-select-selectedcontent>one</span>
</div>
36 changes: 36 additions & 0 deletions ...emantics/forms/the-select-element/customizable-select/select-display-block.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<html class=reftest-wait>
<meta name=fuzzy content="maxDifference=0-3;totalPixels=0-1">
<link rel=author href="mailto:[email protected]">
<link rel=help href="https://github.com/whatwg/html/issues/9799">
<link rel=match href="select-display-block-ref.html">
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<style>
select, ::picker(select) {
appearance: base-select;
}
select {
width: 100px;
}
.block {
display: block;
}
</style>

<select>
<option>one</option>
<option>two</option>
</select>

<script>
(async () => {
await new Promise(requestAnimationFrame);
await new Promise(requestAnimationFrame);
document.querySelector('select').classList.add('block');
await new Promise(requestAnimationFrame);
await new Promise(requestAnimationFrame);
document.documentElement.classList.remove('reftest-wait');
})();
</script>
42 changes: 42 additions & 0 deletions .../semantics/forms/the-select-element/customizable-select/select-grid-before-after-ref.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<!DOCTYPE html>

<style>
div {
display: inline-grid;
width: 200px;
height: 200px;
box-sizing: border-box;
vertical-align: top;
place-items: center;
background: orange;
padding: 8px;
margin: 0;
border: none;
border-radius: 0;
grid-template-rows: 1fr 1fr;
grid-template-columns: 1fr 1fr;
gap: 0;

&::before {
content: 'before';
grid-row: 1;
grid-column: 1;
background: yellow;
padding: 8px;
}

&::after {
content: 'after';
grid-row: 2;
grid-column: 2;
background: yellow;
padding: 8px;
}
}
</style>

<div>
<template shadowrootmode="open">
<div></div>
</template>
</div>
49 changes: 49 additions & 0 deletions html/semantics/forms/the-select-element/customizable-select/select-grid-before-after.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<!DOCTYPE html>
<link rel=author href="mailto:[email protected]">
<link rel=help href="https://issues.chromium.org/issues/452087739">
<link rel=match href="select-grid-before-after-ref.html">

<style>
select {
appearance: base-select;

&::picker-icon {
display: none;
}
}

select {
display: inline-grid;
width: 200px;
height: 200px;
box-sizing: border-box;
vertical-align: top;
place-items: center;
background: orange;
padding: 8px;
margin: 0;
border: none;
border-radius: 0;
grid-template-rows: 1fr 1fr;
grid-template-columns: 1fr 1fr;
gap: 0;

&::before {
content: 'before';
grid-row: 1;
grid-column: 1;
background: yellow;
padding: 8px;
}

&::after {
content: 'after';
grid-row: 2;
grid-column: 2;
background: yellow;
padding: 8px;
}
}
</style>

<select></select>