[Gecko Bug 2003729] Buffer reports by type separately #57038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the spec wants to evict reports due to a maxmimum amount having been exceeded, it does so by report type. This adds the ability to store max of N reports per type. Also added a web platform test to test for ReportingObserver returning test in the correct order as they were added. See step 4 of 4.2: https://www.w3.org/TR/reporting-1/#notify-observers Differential Revision: https://phabricator.services.mozilla.com/D276831 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2003729 gecko-commit: fd6a6f3de14b5e9b131ac58266bb3cd9fa726534 gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Jan 7, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
… assertion failures This reverts commit 8f2a3fac38ddb47db9216164a710c092b278720d. gecko-commit: 0bba2e7eae4781aa38f4e6e97569051cbace5669 gecko-reviewers: smaug
When the spec wants to evict reports due to a maxmimum amount having been exceeded, it does so by report type. This adds the ability to store max of N reports per type. Also added a web platform test to test for ReportingObserver returning test in the correct order as they were added. See step 4 of 4.2: https://www.w3.org/TR/reporting-1/#notify-observers Differential Revision: https://phabricator.services.mozilla.com/D276831 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2003729 gecko-commit: 3b1bce30df11977ee4024a6edabfeae49f2d8cd5 gecko-reviewers: smaug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the spec wants to evict reports due to a maxmimum amount having
been exceeded, it does so by report type.
This adds the ability to store max of N reports per type.
Also added a web platform test to test for ReportingObserver returning
test in the correct order as they were added.
See step 4 of 4.2:
https://www.w3.org/TR/reporting-1/#notify-observers
Differential Revision: https://phabricator.services.mozilla.com/D276831
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2003729
gecko-commit: fd6a6f3de14b5e9b131ac58266bb3cd9fa726534
gecko-reviewers: smaug