Skip to content

[Gecko Bug 2003729] Buffer reports by type separately #57038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moz-wptsync-bot merged 3 commits into from
Jan 9, 2026
Merged

[Gecko Bug 2003729] Buffer reports by type separately #57038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd9d7d5
Buffer reports by type separately
theIDinside Jan 7, 2026
99612bf
Revert "Bug 2003729 - Buffer reports by type separately " for causing…
Jan 7, 2026
db2fb21
Buffer reports by type separately
theIDinside Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions reporting/reporting-api-orders-reports-buffered.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
<!DOCTYPE HTML>
<html>
<head>
<meta charset="utf-8">
<title>
Reporting API: buffered observer preserves ordering across report types
</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>

<body>
<script>
promise_test(async t => {
assert_true("ReportingObserver" in self);

function generateTest(i) {
test_driver.generate_test_report(`Test report ${i}`);
}

function generateDeprecation(i) {
let img = document.createElement("img");

img.src = `/some/bunk/file${i}.png`;
document.body.appendChild(img);
}

let nonBufferedReports = [];
const observeTwoReports = async () => {
let { promise, resolve } = Promise.withResolvers();
let count = 0;
let reportingObserver = new ReportingObserver(reports => {
count += reports.length;
nonBufferedReports.push(...reports);
if (count >= 2) {
resolve();
}
});

reportingObserver.observe();
return promise.finally(() => reportingObserver.disconnect());
}

// Generate interleaved reports
for (let i = 0; i < 25; i++) {
generateTest(i);
generateDeprecation(i);
await observeTwoReports();
}

const collected = [];
const { promise: collectedAll, resolve } = Promise.withResolvers();

const observer = new ReportingObserver(
reports => {
collected.push(...reports);
if (collected.length == nonBufferedReports.length) {
resolve();
}
},
{ buffered: true }
);

observer.observe();

await collectedAll;
observer.disconnect();

assert_greater_than(
collected.length,
0,
"Some reports must be delivered"
);

// Verify relative ordering by type
const observedTypes = collected.map(r => r.type);

assert_array_equals(observedTypes, nonBufferedReports.map(r => r.type));
}, "Buffered ReportingObserver preserves report generation order");
</script>
</body>
</html>
7 changes: 7 additions & 0 deletions reporting/reporting-api-orders-reports-buffered.https.html.sub.headers
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Expires: Mon, 26 Jul 1997 05:00:00 GMT
Cache-Control: no-store, no-cache, must-revalidate
Cache-Control: post-check=0, pre-check=0, false
Pragma: no-cache
Set-Cookie: reporting-api-sends-reports-on-violation={{$id:uuid()}}; Path=/content-security-policy/reporting-api
Reporting-Endpoints: csp-group="https://{{host}}:{{ports[https][0]}}/reporting/resources/report.py?op=put&reportID={{$id}}"
Content-Security-Policy: script-src 'self' 'unsafe-inline'; img-src 'none'; report-to csp-group