Rename CrashReportStorage, and its remove() method #57117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7422847
branch
2 times, most recently
from
8bc92b6 to
fa949af
Compare
This CL renames CrashReportStorage to CrashReportContext, per W3C TAG feedback [1], and the remove() method to delete(), per other community feedback [2]. WICG/crash-reporting#37 will be updated separately. [1]: w3ctag/design-reviews#1129 [2]: WICG/crash-reporting#38 R=dcheng Bug: 400432195 Change-Id: I41025804d22b0bbd11a5fe93f8bdf6656df82b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7422847 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: mmenke <mmenke@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1568186}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7422847
branch
from
fa949af to
65b27ff
Compare
wpt-pr-bot
approved these changes
Jan 13, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL renames CrashReportStorage to CrashReportContext, per W3C TAG
feedback 1, and the remove() method to delete(), per other community
feedback 2.
WICG/crash-reporting#37 will be updated
separately.
R=dcheng
Bug: 400432195
Change-Id: I41025804d22b0bbd11a5fe93f8bdf6656df82b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7422847
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568186}