Skip to content

Rename CrashReportStorage, and its remove() method #57117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Jan 13, 2026
Merged

Rename CrashReportStorage, and its remove() method #57117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions reporting/crashReport-test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!DOCTYPE html>
<meta charset=utf-8>
<title>CrashReportStorage API</title>
<title>CrashReportContext API</title>
<link rel="author" title="Dominic Farolino" href="mailto:dom@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
Expand Down Expand Up @@ -81,9 +81,9 @@
assert_throws_dom('InvalidStateError', child_window.DOMException, () => {
// Detach the document.
iframe.remove();
cachedCrashReport.remove('key', 'value');
cachedCrashReport.delete('key', 'value');
});
}, 'crashReport.remove() throws InvalidStateError in detached Documents');
}, 'crashReport.delete() throws InvalidStateError in detached Documents');

promise_test(async t => {
const iframe = document.createElement('iframe');
Expand Down Expand Up @@ -136,7 +136,7 @@
const child_window = iframe.contentWindow;
await child_window.crashReport.initialize(1024);
child_window.crashReport.set('key', 'value');
child_window.crashReport.remove('key');
child_window.crashReport.delete('key');
}, 'crashReport.set() and .remove() succeed after initialize() resolves');

promise_test(async t => {
Expand Down Expand Up @@ -180,10 +180,10 @@
assert_throws_dom('NotAllowedError', child_window.DOMException, () => {
child_window.crashReport.set('b', 'b');
});
child_window.crashReport.remove('a');
child_window.crashReport.delete('a');
// Now `set()` will work again.
child_window.crashReport.set('b', 'b');
}, 'crashReport.remove() properly frees memory, and allows you to invoke ' +
}, 'crashReport.delete() properly frees memory, and allows you to invoke ' +
'set() again, assigning bytes to memory that was previously full');
</script>
</body>