Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner case invoker issue with popover nested inside invoker #10770

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Nov 16, 2024

  1. Fix corner case invoker issue with popover nested inside invoker

    In this situation:
    
    ```
    <button popovertarget=foo>Activate
      <div popover id=foo>Clicking me shouldn't close me</div>
    </button>
    ```
    
    clicking the button properly activates the popover, however, clicking on the popover itself after that should **not** close the popover. It currently does because the popover click bubbles to the `<button>` and activates the invoker, which toggles the popover closed.
    
    This patch fixes that case.
    mfreed7 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b28a9f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Fix nesting problem

    mfreed7 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    81b5b7f View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Address comments

    mfreed7 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3f5cffe View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. EventTarget->Node

    mfreed7 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4e75996 View commit details
    Browse the repository at this point in the history