Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner case invoker issue with popover nested inside invoker #10770

Merged
merged 4 commits into from
Nov 22, 2024
+10 −5
Merged

Fix corner case invoker issue with popover nested inside invoker #10770

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b28a9f9
Fix corner case invoker issue with popover nested inside invoker
mfreed7 Nov 16, 2024
81b5b7f
Fix nesting problem
mfreed7 Nov 17, 2024
3f5cffe
Address comments
mfreed7 Nov 18, 2024
4e75996
EventTarget->Node
mfreed7 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48192,8 +48192,8 @@ interface <dfn interface>HTMLInputElement</dfn> : <span>HTMLElement</span> {
<li><p>Run <var>element</var>'s <dfn>input activation behavior</dfn>, if any, and do nothing
otherwise.</p></li>

<li><p>Run the <span>popover target attribute activation behavior</span> on
<var>element</var>.</p></li>
<li><p>Run the <span>popover target attribute activation behavior</span> given <var>element</var>
and <var>event</var>'s <span data-x="concept-event-target">target</span>.</p></li>
</ol>
mfreed7 marked this conversation as resolved.
Show resolved Hide resolved

<p class="note">Recall that an element's <span>activation behavior</span> runs for both
Expand Down Expand Up @@ -53490,8 +53490,8 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> {
</dl>
</li>

<li><p>Run the <span>popover target attribute activation behavior</span> given
<var>element</var>.</p></li>
<li><p>Run the <span>popover target attribute activation behavior</span> given <var>element</var>
and <var>event</var>'s <span data-x="concept-event-target">target</span>.</p></li>
</ol>

</div>
Expand Down Expand Up @@ -86359,13 +86359,18 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
attribute, <span>limited to only known values</span>.</p>

<p>To run the <dfn>popover target attribute activation behavior</dfn> given a <code>Node</code>
<var>node</var>:</p>
<var>node</var> and a <code>Node</code> <var>eventTarget</var>:</p>
mfreed7 marked this conversation as resolved.
Show resolved Hide resolved

<ol>
mfreed7 marked this conversation as resolved.
Show resolved Hide resolved
<li><p>Let <var>popover</var> be <var>node</var>'s <span>popover target element</span>.</p></li>

<li><p>If <var>popover</var> is null, then return.</p></li>
mfreed7 marked this conversation as resolved.
Show resolved Hide resolved

<li><p>If <var>eventTarget</var> is a <span>shadow-including inclusive descendant</span> of
<var>popover</var> and <var>popover</var> is a
<span data-x="shadow-including descendant">shadow-including descendant</span> of <var>node</var>,
then return.</p></li>
mfreed7 marked this conversation as resolved.
Show resolved Hide resolved

mfreed7 marked this conversation as resolved.
Show resolved Hide resolved
<li><p>If <var>node</var>'s <code data-x="attr-popovertargetaction">popovertargetaction</code>
attribute is in the <span data-x="attr-popovertargetaction-show">show</span> state and
<var>popover</var>'s <span>popover visibility state</span> is <span
Expand Down