Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting Started notebook to use init #1365

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

naddeoa
Copy link
Contributor

@naddeoa naddeoa commented Sep 8, 2023

Just a small sample of how the docs/ux will look after the update to include init(). We can use this to make tweaks or back compat fixes before switching more things over.

Gaps:

  • There isn't an easy way to make segmented classification/regression metrics work because those don't use why.log under the hood, so I'll have to make a custom integration for them at some point. Just left those examples the same (no init).

@naddeoa naddeoa self-assigned this Sep 8, 2023
murilommen
murilommen previously approved these changes Sep 18, 2023
Copy link
Contributor

@murilommen murilommen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the pre-commit errors and updating the branch with the latest changes, this looks like what we need for the examples with why.init

Just a small sample of how the docs/ux will look after the update to
include init(). We can use this to make tweaks or back compat fixes
before switching more things over.

Gaps:
- There isn't an easy way to make segmented classification/regression
  metrics work because those don't use why.log under the hood, so I'll
  have to make a custom integration for them at some point. Just left
  those examples the same (no init).
@naddeoa naddeoa force-pushed the dev/anthony/doc-update-1 branch from 76df8a3 to 6a8e969 Compare September 22, 2023 17:45
Copy link
Contributor

@FelipeAdachi FelipeAdachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit d5f8faf into mainline Sep 26, 2023
18 checks passed
@jamie256 jamie256 deleted the dev/anthony/doc-update-1 branch September 26, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants