impl Compare<&str> and Compare<&[u8]> for AsRef<[u8]>#635
Draft
soulstompp wants to merge 1 commit intowinnow-rs:mainfrom
Draft
impl Compare<&str> and Compare<&[u8]> for AsRef<[u8]>#635soulstompp wants to merge 1 commit intowinnow-rs:mainfrom
soulstompp wants to merge 1 commit intowinnow-rs:mainfrom
Conversation
Pull Request Test Coverage Report for Build 12375039177Details
💛 - Coveralls |
Author
|
I will get the commit message fixed to make the linter happy but not sure what the proper description should be since it seemed like a |
soulstompp
force-pushed
the
asref-u8-compare
branch
2 times, most recently
from
f220375 to
5c422a2
Compare
soulstompp
force-pushed
the
asref-u8-compare
branch
from
5c422a2 to
b8826a1
Compare
epage
added
the
M-breaking-change
Collaborator
|
As this needs more design discussion in #634, I'm marking this as a Draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impl AsRef<[u8]> for &str and &[u8] as mentioned in issue #634. This makes the code slightly more manageable and helps with performance.