Skip to content

impl Compare<&str> and Compare<&[u8]> for AsRef<[u8]> #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
soulstompp wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

impl Compare<&str> and Compare<&[u8]> for AsRef<[u8]> #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 28 additions & 42 deletions src/stream/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2186,15 +2186,37 @@ pub trait Compare<T> {
fn compare(&self, t: T) -> CompareResult;
}

impl<'a, 'b> Compare<&'b [u8]> for &'a [u8] {
#[inline]
fn compare(&self, t: &'b [u8]) -> CompareResult {
if t.iter().zip(*self).any(|(a, b)| a != b) {
impl<T> Compare<&str> for T
where
T: AsRef<[u8]>,
{
fn compare(&self, t: &str) -> CompareResult {
let self_bytes = self.as_ref();
let t_bytes = t.as_bytes();

if t_bytes.iter().zip(self_bytes).any(|(a, b)| a != b) {
CompareResult::Error
} else if self.len() < t.slice_len() {
} else if self_bytes.len() < t_bytes.len() {
CompareResult::Incomplete
} else {
CompareResult::Ok(t.slice_len())
CompareResult::Ok(t_bytes.len())
}
}
}

impl<T> Compare<&[u8]> for T
where
T: AsRef<[u8]>,
{
fn compare(&self, t: &[u8]) -> CompareResult {
let self_bytes = self.as_ref();

if t.iter().zip(self_bytes).any(|(a, b)| a != b) {
CompareResult::Error
} else if self_bytes.len() < t.len() {
CompareResult::Incomplete
} else {
CompareResult::Ok(t.len())
}
}
}
Expand Down Expand Up @@ -2244,13 +2266,6 @@ impl<'a, 'b, const LEN: usize> Compare<AsciiCaseless<&'b [u8; LEN]>> for &'a [u8
}
}

impl<'a, 'b> Compare<&'b str> for &'a [u8] {
#[inline(always)]
fn compare(&self, t: &'b str) -> CompareResult {
self.compare(t.as_bytes())
}
}

impl<'a, 'b> Compare<AsciiCaseless<&'b str>> for &'a [u8] {
#[inline(always)]
fn compare(&self, t: AsciiCaseless<&'b str>) -> CompareResult {
Expand Down Expand Up @@ -2294,13 +2309,6 @@ impl<'a> Compare<AsciiCaseless<char>> for &'a [u8] {
}
}

impl<'a, 'b> Compare<&'b str> for &'a str {
#[inline(always)]
fn compare(&self, t: &'b str) -> CompareResult {
self.as_bytes().compare(t.as_bytes())
}
}

impl<'a, 'b> Compare<AsciiCaseless<&'b str>> for &'a str {
#[inline(always)]
fn compare(&self, t: AsciiCaseless<&'b str>) -> CompareResult {
Expand All @@ -2322,28 +2330,6 @@ impl<'a> Compare<AsciiCaseless<char>> for &'a str {
}
}

impl<'a, T> Compare<T> for &'a Bytes
where
&'a [u8]: Compare<T>,
{
#[inline(always)]
fn compare(&self, t: T) -> CompareResult {
let bytes = (*self).as_bytes();
bytes.compare(t)
}
}

impl<'a, T> Compare<T> for &'a BStr
where
&'a [u8]: Compare<T>,
{
#[inline(always)]
fn compare(&self, t: T) -> CompareResult {
let bytes = (*self).as_bytes();
bytes.compare(t)
}
}

impl<I, U> Compare<U> for Located<I>
where
I: Compare<U>,
Expand Down