-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly updating draft message [WPB-14271] #3104
fix: Properly updating draft message [WPB-14271] #3104
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3104 +/- ##
==================================================
Coverage 52.64% 52.64%
==================================================
Files 1321 1321
Lines 51615 51615
Branches 4781 4781
==================================================
+ Hits 27171 27172 +1
Misses 22487 22487
+ Partials 1957 1956 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3157 Passed, 107 Skipped, 34.55s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mateusz Zagórski <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
https://wearezeta.atlassian.net/browse/WPB-14271
What's new in this PR?
Issues
We could not get rid of quoted or edited message from draft
Causes (Optional)
We were trying to update draft values to null when removing quoted or edited messages which was failing on the database query check, so in fact we're never updating actual value to a default null one
Solutions
Changed
!=
check in database toIS NOT
- comparing value andnull
with!=
is returningNULL
nottrue
orfalse
if Im not mistaken. I've also added tests to cover other draft fields updatePR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.