Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly updating draft message [WPB-14271] #3104

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 13, 2024

BugWPB-14271 [Android] reply draft is not cleared when clicking the x icon

https://wearezeta.atlassian.net/browse/WPB-14271

What's new in this PR?

Issues

We could not get rid of quoted or edited message from draft

Causes (Optional)

We were trying to update draft values to null when removing quoted or edited messages which was failing on the database query check, so in fact we're never updating actual value to a default null one

Solutions

Changed != check in database to IS NOT - comparing value and null with != is returning NULL not true or false if Im not mistaken. I've also added tests to cover other draft fields update


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Test Results

3 264 tests  +6   3 157 ✅ +6   4m 42s ⏱️ +15s
  555 suites ±0     107 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 23f0fd5. ± Comparison against base commit 2c1b2da.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.64%. Comparing base (2c1b2da) to head (23f0fd5).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3104   +/-   ##
==================================================
  Coverage              52.64%   52.64%           
==================================================
  Files                   1321     1321           
  Lines                  51615    51615           
  Branches                4781     4781           
==================================================
+ Hits                   27171    27172    +1     
  Misses                 22487    22487           
+ Partials                1957     1956    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1b2da...23f0fd5. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/updating-draft-message-fields
Commit report: 3af3e8c
Test service: kalium-jvm

✅ 0 Failed, 3157 Passed, 107 Skipped, 34.55s Total Time

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-zagorski m-zagorski added this pull request to the merge queue Nov 14, 2024
Merged via the queue into release/candidate with commit 7440f44 Nov 14, 2024
21 checks passed
@m-zagorski m-zagorski deleted the fix/updating-draft-message-fields branch November 14, 2024 09:33
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2024
Co-authored-by: Mateusz Zagórski <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants