Skip to content

feat: add usecase to get team url (WPB-14872)#3157

Merged
ohassine merged 4 commits intodevelopfrom
add-use-case-to-get-team-url
Dec 11, 2024
Merged

feat: add usecase to get team url (WPB-14872)#3157
ohassine merged 4 commits intodevelopfrom
add-use-case-to-get-team-url

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Dec 9, 2024

TaskWPB-14872 [Android] Wrong URL when opening team management after migration from button


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need this use case to get the team url based on the current environment. Currently, it's static, we use the prod link

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 9, 2024

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2024

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 28s ⏱️ -29s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 431e549. ± Comparison against base commit 46ab0bc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 9, 2024

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 9, 2024

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.19%. Comparing base (46ab0bc) to head (431e549).
⚠️ Report is 693 commits behind head on develop.

Files with missing lines Patch % Lines
...e/kalium/logic/feature/server/GetTeamUrlUseCase.kt 0.00% 4 Missing ⚠️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 25.00% 3 Missing ⚠️
...gic/configuration/server/ServerConfigRepository.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3157      +/-   ##
===========================================
- Coverage    54.20%   54.19%   -0.02%     
===========================================
  Files         1249     1250       +1     
  Lines        36449    36458       +9     
  Branches      3688     3689       +1     
===========================================
  Hits         19757    19757              
- Misses       15269    15277       +8     
- Partials      1423     1424       +1     
Files with missing lines Coverage Δ
...gic/configuration/server/ServerConfigRepository.kt 63.51% <0.00%> (-0.88%) ⬇️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 57.48% <25.00%> (-1.06%) ⬇️
...e/kalium/logic/feature/server/GetTeamUrlUseCase.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ab0bc...431e549. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-wireapp
Copy link
Copy Markdown

Datadog Report

Branch report: add-use-case-to-get-team-url
Commit report: 11c2c29
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 10.24s Total Time

@ohassine ohassine requested review from a team, MohamadJaara, sergeibakhtiarov, typfel, vitorhugods and yamilmedina and removed request for a team December 11, 2024 08:39
@ohassine ohassine added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit abcd037 Dec 11, 2024
@ohassine ohassine deleted the add-use-case-to-get-team-url branch December 11, 2024 11:38
ohassine added a commit that referenced this pull request Dec 11, 2024
* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt

(cherry picked from commit abcd037)
ohassine added a commit that referenced this pull request Dec 11, 2024
ohassine added a commit that referenced this pull request Dec 11, 2024
* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt

(cherry picked from commit abcd037)
github-merge-queue Bot pushed a commit that referenced this pull request Dec 11, 2024
* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt

(cherry picked from commit abcd037)
github-merge-queue Bot pushed a commit that referenced this pull request Jan 9, 2025
* feat: harden ClientCapabilityDTO for api v7

* add tests

* detekt

* detekt

* chore: disable folders update handler (#3161)

* fix: Login to second device does not have MLS capabilities RC (#3165)

* feat: add usecase to get team url (WPB-14872) (#3157) (#3168)

* feat: add usecase to get team url

* feat:detekt

* feat: detekt

* feat: detekt

(cherry picked from commit abcd037)

* chore: upgrade to cc3, fixes new_transaction in paralell (#3170)

* test: add tests for old format parser in capabilities (#3173)

* Update libs.versions.toml

* Update UserPropertiesEventReceiver.kt

* Update UserPropertiesEventReceiver.kt

* Update UserPropertiesEventReceiverTest.kt

* fix

* fix tests

* missing imports

* fix circular dependency

* Trigger CI

* remove not needed dependency

---------

Co-authored-by: Jakub Żerko <iot.zerko@gmail.com>
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Co-authored-by: boris <boris.safonov@appunite.com>
Co-authored-by: Oussama Hassine <oussama.has100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants