Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inject self profile views monitor - WPB-15038 #2331

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: inject self profile views monitor - WPB-15038 #2331

merged 2 commits into from
Jan 6, 2025

Conversation

El-Fitz
Copy link
Contributor

@El-Fitz El-Fitz commented Dec 24, 2024

Issue

The SelfProfileViewsMonitor is now injected, and a mock has been provided for testing purposes.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@El-Fitz El-Fitz self-assigned this Dec 24, 2024
@echoes-hq echoes-hq bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: unplanned/support Work items completed to meet a customer or user support request. echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes/initiative: personal-users-to-team-users... labels Dec 24, 2024
@caldrian caldrian changed the base branch from develop to release/cycle-3.115 January 3, 2025 08:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Test Results

    1 files      2 suites   1m 56s ⏱️
1 789 tests 1 763 ✅ 26 💤 0 ❌
1 799 runs  1 773 ✅ 26 💤 0 ❌

Results for commit 3dbda2d.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 3, 2025 •
edited
Loading

Datadog Report

Branch report: feat/inject-self-profile-views-monitor
Commit report: 0d09f0a
Test service: wire-ios-mono

✅ 0 Failed, 1685 Passed, 26 Skipped, 1m 55.66s Total Time

@El-Fitz El-Fitz force-pushed the feat/inject-self-profile-views-monitor branch from a8a3b97 to 3dbda2d Compare January 6, 2025 11:50
@El-Fitz El-Fitz merged commit 5ba8bf1 into release/cycle-3.115 Jan 6, 2025
11 of 12 checks passed
@El-Fitz El-Fitz deleted the feat/inject-self-profile-views-monitor branch January 6, 2025 12:24
zenkins pushed a commit that referenced this pull request Jan 6, 2025
@El-Fitz @github-actions
feat: inject self profile views monitor - WPB-15038 (#2331)
136aa64
@github-actions github-actions bot mentioned this pull request Jan 6, 2025
Merged
3 tasks
El-Fitz added a commit that referenced this pull request Jan 7, 2025
@El-Fitz
feat: inject self profile views monitor - WPB-15038 (#2331)
c1d6a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caldrian caldrian caldrian approved these changes

@samwyndham samwyndham samwyndham approved these changes

@netbe netbe Awaiting requested review from netbe

Assignees

@El-Fitz El-Fitz

Labels
echoes/initiative: personal-users-to-team-users... echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned/support Work items completed to meet a customer or user support request. echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@El-Fitz @samwyndham @caldrian