gundeck/cannon: Fixup for temporary recipients of events #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
rabbitmq-temp-clients-fixup
branch
from
ef99a8b to
d60fc4a
Compare
akshaymankar
changed the title
echoes-hq
bot
added
the
echoes/initiative: scale
…ser doesn't have any regular RabbitMQ clients
Also: - Extract function to create RabbitMQAdminClient for a backend resource - Extract function to runDynamicBackends returning the BackendResources instead of returning just the domains.
Also: * Use Data.Unique.Unqiue to keep track of channels instead of (ByteString, ByteString) because it is way less fuss to generate the Unqiue and it doesn't really need to be (UserId, ClientId) tuple. This also removes polymorphism for the RabbitMqPool type. * Log conneciton close while draining at Debug level instead of Info
The race in these tests is between the RabbitMQ exchange doing the fanout for previous events and the test creating a temporary queue.
akshaymankar
force-pushed
the
rabbitmq-temp-clients-fixup
branch
from
d60fc4a to
bfc7865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-11173
Checklist
Add a new entry in an appropriate subdirectory ofNo chagelog, this is just a fixup. The changelog got deleted in release, its too complicated to summarize this fixup now.changelog.d